From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mx.groups.io with SMTP id smtpd.web11.2786.1645823933160610123
 for <devel@edk2.groups.io>;
 Fri, 25 Feb 2022 13:18:53 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linux.microsoft.com header.s=default header.b=kHbH0Boz;
 spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com)
Received: from [192.168.4.22] (unknown [47.201.46.66])
	by linux.microsoft.com (Postfix) with ESMTPSA id C082220B7178;
	Fri, 25 Feb 2022 13:18:51 -0800 (PST)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com C082220B7178
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
	s=default; t=1645823932;
	bh=jLfxOJJcnS3/7OdGH+PWwT5ceQT0WE3dOErWobD7ydc=;
	h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
	b=kHbH0BozL+w5UPVWPfHWELPaalgEMuvT0yKhOfP82E07oiO2813zmnzdShW07CknT
	 fcIe17IJ+zAmpcGIp+t1RZs8ohDVrqQWf1AVaEPhIFUmJhBFWtqZ0qqVzo5Hn9Geis
	 CH81dq7wBx0TAx8W2uMSRf1I25wVCb7d37SLxkfw=
Message-ID: <d12c1b4f-4706-2a20-a9e5-6d434d65b832@linux.microsoft.com>
Date: Fri, 25 Feb 2022 16:18:50 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.1
Subject: Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default
To: Rebecca Cran <quic_rcran@quicinc.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Liming Gao <gaoliming@byosoft.com.cn>,
 Sean Brogan <sean.brogan@microsoft.com>,
 Bret Barkelew <Bret.Barkelew@microsoft.com>
References: <20220210161927.1847-1-mikuback@linux.microsoft.com>
 <7ab3cb92-85e1-c8ec-fc4e-20ae84a65c2f@quicinc.com>
From: "Michael Kubacki" <mikuback@linux.microsoft.com>
In-Reply-To: <7ab3cb92-85e1-c8ec-fc4e-20ae84a65c2f@quicinc.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Rebecca,

Sorry for the delay, I was out of office.

The diff will appear in <Workspace>/Build/TestSuites.xml. Here, I have 
intentionally introduced an error in 
UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c:

  Uncrustify executed against 21 files in UnitTestFrameworkPkg in 0.19 
seconds.
  </system-out><system-err>Files with formatting errors:
  Formatting errors in Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c
  --- 
D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c
  +++ 
D:\src\edk2\UnitTestFrameworkPkg\Test\UnitTest\Sample\SampleUnitTest\SampleUnitTest.c.uncrustify_plugin
  @@ -13,7 +13,7 @@
  #include &lt;Library/UnitTestLib.h&gt;
  #include &lt;Library/PrintLib.h&gt;

  -#define UNIT_TEST_NAME        "Sample Unit Test"
  +#define UNIT_TEST_NAME     "Sample Unit Test"
  #define UNIT_TEST_VERSION  "0.1"

  ///

  </system-err></testcase></testsuite></testsuites>

Thanks,
Michael

On 2/23/2022 12:48 PM, Rebecca Cran wrote:
> This doesn't appear to work. If I change 
> MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c to introduce an error, 
> then I get the following output (with verbose mode):
> 
> 
> INFO - ------------------------------------------------
> INFO - --------------Cmd Output Finished---------------
> INFO - --------- Running Time (mm:ss): 00:07 ----------
> INFO - ----------- Return Code: 0x00000000 ------------
> INFO - ------------------------------------------------
> INFO - Uncrustify executed against 1035 files in MdeModulePkg in 7.67 
> seconds.
> 
> INFO - Calculating file diffs. This might take a while...
> ERROR - .../edk2/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.c
> ERROR - --->Test Failed: Uncrustify Coding Standard Test NO-TARGET 
> returned 1
> PROGRESS - --Running MdeModulePkg: Spell Check Test NO-TARGET --
> 
> So it's seeing that _output_file_diffs is True, but it appears that 
> there aren't any formatted_files?
> 
>