From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B714221B00DC1 for ; Tue, 21 Nov 2017 07:36:31 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B8BEAA58A5; Tue, 21 Nov 2017 15:40:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-145.rdu2.redhat.com [10.10.120.145]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED6A617A94; Tue, 21 Nov 2017 15:40:45 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: leif.lindholm@linaro.org References: <20171117160913.17292-1-ard.biesheuvel@linaro.org> <20171117160913.17292-5-ard.biesheuvel@linaro.org> From: Laszlo Ersek Message-ID: Date: Tue, 21 Nov 2017 16:40:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171117160913.17292-5-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 21 Nov 2017 15:40:46 +0000 (UTC) Subject: Re: [PATCH 04/15] ArmVirtPkg/PrePi: remove bogus primary core check X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 15:36:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/17/17 17:09, Ard Biesheuvel wrote: > QEMU and KVM based ARM/AARCH64 virtual machines only enter UEFI on > a single core, so ArmPlatformIsPrimaryCore() always returns true. > And even if it didn't, our code does absolutely nothing meaningful > based on its return value, so don't bother calling it, and remove > another frivolous dependency on ArmPlatformLib. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel > --- > ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S | 7 ------- > ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S | 7 ------- > 2 files changed, 14 deletions(-) > > diff --git a/ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S b/ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S > index cc8b47e69026..7a9c0c3787cc 100644 > --- a/ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S > +++ b/ArmVirtPkg/PrePi/AArch64/ModuleEntryPoint.S > @@ -128,13 +128,6 @@ _GetStackBase: > MOV32 (x3, FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) > bl ASM_PFX(ArmPlatformStackSet) > > - // Is it the Primary Core ? > - mov x0, x10 > - bl ASM_PFX(ArmPlatformIsPrimaryCore) > - cmp x0, #1 > - bne _PrepareArguments > - > -_PrepareArguments: > mov x0, x20 > mov x1, x21 > mov x2, x22 > diff --git a/ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S b/ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S > index 59028d0a553e..eebf660acdb2 100644 > --- a/ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S > +++ b/ArmVirtPkg/PrePi/Arm/ModuleEntryPoint.S > @@ -136,13 +136,6 @@ _GetStackBase: > MOV32 (r3, FixedPcdGet32(PcdCPUCoreSecondaryStackSize)) > bl ASM_PFX(ArmPlatformStackSet) > > - // Is it the Primary Core ? > - mov r0, r10 > - bl ASM_PFX(ArmPlatformIsPrimaryCore) > - cmp r0, #1 > - bne _PrepareArguments > - > -_PrepareArguments: > mov r0, r10 > mov r1, r11 > mov r2, r9 > I'll assume ArmPlatformIsPrimaryCore has no side effects. Beyond that, even I can see that conditional-jump LABEL LABEL: ... is a no-op :) Reviewed-by: Laszlo Ersek