From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out02.mta.xmission.com (out02.mta.xmission.com [166.70.13.232]) by mx.groups.io with SMTP id smtpd.web10.145.1581351868131035148 for ; Mon, 10 Feb 2020 08:24:28 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: bsdio.com, ip: 166.70.13.232, mailfrom: rebecca@bsdio.com) Received: from in01.mta.xmission.com ([166.70.13.51]) by out02.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1j1BrG-0002dc-UA; Mon, 10 Feb 2020 09:24:26 -0700 Received: from mta2.zcs.xmission.com ([166.70.13.66]) by in01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1j1BrF-0005tJ-Nd; Mon, 10 Feb 2020 09:24:26 -0700 Received: from mta2.zcs.xmission.com (localhost [127.0.0.1]) by mta2.zcs.xmission.com (Postfix) with ESMTPS id 6F56D6002EA; Mon, 10 Feb 2020 09:24:25 -0700 (MST) Received: from localhost (localhost [127.0.0.1]) by mta2.zcs.xmission.com (Postfix) with ESMTP id 55BE86002E2; Mon, 10 Feb 2020 09:24:25 -0700 (MST) X-Amavis-Modified: Mail body modified (using disclaimer) - mta2.zcs.xmission.com Received: from mta2.zcs.xmission.com ([127.0.0.1]) by localhost (mta2.zcs.xmission.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id iKAtWVmn0liJ; Mon, 10 Feb 2020 09:24:25 -0700 (MST) Received: from photon.int.bluestop.org (c-174-52-16-57.hsd1.ut.comcast.net [174.52.16.57]) (Authenticated sender: rebecca@bsdio.com) by mta2.zcs.xmission.com (Postfix) with ESMTPSA id 1A43D600015; Mon, 10 Feb 2020 09:24:25 -0700 (MST) To: "Schaefer, Daniel Helmut (DualStudy)" Cc: "Chang, Abner (HPS SW/FW Technologist)" , "Chen, Gilbert" , "devel@edk2.groups.io" References: <28f9f325-3106-1f3a-096d-d3aebc6fcc85@bsdio.com> From: "Rebecca Cran" Message-ID: Date: Mon, 10 Feb 2020 09:24:24 -0700 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: X-XM-SPF: eid=1j1BrF-0005tJ-Nd;;;mid=;;;hst=in01.mta.xmission.com;;;ip=166.70.13.66;;;frm=rebecca@bsdio.com;;;spf=none X-SA-Exim-Connect-IP: 166.70.13.66 X-SA-Exim-Mail-From: rebecca@bsdio.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa04.xmission.com X-Spam-Level: * X-Spam-Status: No, score=1.7 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, T_TooManySym_02,T_TooManySym_03,XMSubLong,XM_B_Unicode, XM_Multi_Part_URI autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.0 XM_B_Unicode BODY: Testing for specific types of unicode * 1.2 XM_Multi_Part_URI URI: Long-Multi-Part URIs * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; IP=ok Body=1 Fuz1=1] [Fuz2=1] * 0.0 T_TooManySym_03 6+ unique symbols in subject * 0.0 T_TooManySym_02 5+ unique symbols in subject * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; IP=ok Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;"Schaefer, Daniel Helmut (DualStudy)" X-Spam-Relay-Country: X-Spam-Timing: total 833 ms - load_scoreonly_sql: 0.04 (0.0%), signal_user_changed: 2.7 (0.3%), b_tie_ro: 1.87 (0.2%), parse: 1.11 (0.1%), extract_message_metadata: 19 (2.3%), get_uri_detail_list: 4.2 (0.5%), tests_pri_-1000: 5 (0.7%), tests_pri_-950: 1.12 (0.1%), tests_pri_-900: 0.77 (0.1%), tests_pri_-90: 36 (4.3%), check_bayes: 35 (4.1%), b_tokenize: 13 (1.6%), b_tok_get_all: 11 (1.3%), b_comp_prob: 3.4 (0.4%), b_tok_touch_all: 4.5 (0.5%), b_finish: 0.60 (0.1%), tests_pri_0: 754 (90.5%), check_dkim_signature: 0.60 (0.1%), check_dkim_adsp: 86 (10.3%), poll_dns_idle: 76 (9.1%), tests_pri_10: 2.1 (0.3%), tests_pri_500: 8 (1.0%), rewrite_mail: 0.00 (0.0%) Subject: Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc. X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in01.mta.xmission.com) Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2020-02-10 08:13, Schaefer, Daniel Helmut (DualStudy) wrote: > if you want to update to opensbi master, please apply this patch. > Since opensbi 0.6 hasn't been released yet, we haven't pushed the > fixes yet. > Atish said it will be out soon. Thanks! That worked, with a couple of changes. It seems commit ec29e1cf73ffe96a646daa7c2b288aa280e4be37 isn't in the opensbi repo, and the latest master code requires the following patch (I'm assuming 64-bit MMIO _is_ supported!): diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Ope= nsbiPlatformLib/Platform.c b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Ope= nsbiPlatformLib/Platform.c index 3b3637995d..f72122b21b 100644 --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Ope= nsbiPlatformLib/Platform.c +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/Library/Ope= nsbiPlatformLib/Platform.c @@ -168,7 +168,7 @@ static int U540_timer_init(bool cold_boot) =A0 =A0=A0=A0=A0 if (cold_boot) { =A0=A0=A0=A0=A0=A0=A0=A0 rc =3D clint_cold_timer_init(CLINT_REG_BASE_ADDR= , -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540_= HART_COUNT); +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 U540_= HART_COUNT, TRUE);^M =A0=A0=A0=A0=A0=A0=A0=A0 if (rc) =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return rc; =A0=A0=A0=A0 } I don't know if Platform/SiFive/U5SeriesPkg/Readme.md is still used, but I noticed it's a bit out-of-date, and I believe the following patch fixes some issues including typos: diff --git a/Platform/SiFive/U5SeriesPkg/Readme.md b/Platform/SiFive/U5SeriesPkg/Readme.md index 535fa9d430..d6db7c9150 100644 --- a/Platform/SiFive/U5SeriesPkg/Readme.md +++ b/Platform/SiFive/U5SeriesPkg/Readme.md @@ -4,8 +4,8 @@ U5 series core platforms. Currently the supported platforms are Freedom =A0U500 VC707 platform and Freedom U540 HiFive Unleashed platform. =A0 =A0Both platforms are built with below common packages, -- **U5SeriesPkg**, edk2 platform branch -=A0 (Currently is in edk2-platforms/devel-riscv-v2-PATCHv5 branch) +- **U5SeriesPkg**, edk2-platforms master branch^M +=A0 (Currently is in edk2-platforms/devel-riscvplatforms branch)^M =A0- **RiscVPlatformPkg**, edk2 master branch =A0=A0 (Currently is in edk2-staging/RISC-V-V2 branch) =A0- **RiscVPkg**, edk2 master branch @@ -17,11 +17,11 @@ VC707 FPGA Dev Kit, please refer to "SiFive Freedom U500 VC707 FPGA Getting =A0Started Guide" on https://www.sifive.com/documentation. =A0 =A0## U540 Platform -This is a sample RISC-V EDK2 platform package used agaist SiFive Freedom U540 +This is a sample RISC-V EDK2 platform package used against SiFive Freedom U540^M =A0HiFive Unleashed development board, please refer to "SiFive Freedom U540-C000 =A0Manual" on https://www.sifive.com. -The binary built from Platform/SiFive/FreedomU540HiFiveUnleashedBoard can run -on main stream [QEMU](https://git.qemu.org/?p=3Dqemu.git;a=3Dsummary) +The binary built from Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/^M +can run on main stream [QEMU](https://git.qemu.org/?p=3Dqemu.git;a=3Dsum= mary)^M =A0using qemu-system-riscv64 under riscv64-softmmu. Launch the binary wit= h =A0 =A0``` @@ -33,8 +33,7 @@ using qemu-system-riscv64 under riscv64-softmmu. Launch the binary with =A0git clone https://github.com/tianocore/edk2-staging.git =A0# Checkout RISC-V-V2 branch =A0git clone https://github.com/tianocore/edk2-platforms.git -# Checkout devel-riscv-v2-PATCHv5 branch -git clone https://github.com/tianocore/edk2-non-osi.git +# Checkout devel-riscvplatforms branch^M =A0``` =A0 =A0## Platform Owners @@ -47,7 +46,7 @@ FPGA to EFI shell with console in/out enabled. =A0 =A0## Linux Build Instructions =A0You can build the RISC-V platform using below script, -`build -a RISCV64=A0 -t GCC5 -p Platform/SiFive/FreedomU500VC707Board/U500.dsc` +`build -a RISCV64 -t GCC5 -p Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc`^M =A0 =A0## Supported Operating Systems =A0Only support to boot to EFI Shell so far. @@ -68,18 +67,18 @@ RISC-V related SMBIOS records to support the unified boot loader and OS image. =A0This library leverage the silicon libraries provided in Silicon/SiFive= . =A0 =A0### RiscVPlatformTimerLib -This is common U5 series=A0 platform timer library which has the +This is common U5 series platform timer library which has the^M =A0platform-specific timer implementation. =A0 =A0### TimerDxe -This is U5 series=A0 platform timer DXE driver whcih has the platform-specific +This is U5 series platform timer DXE driver which has the platform-specific^M =A0timer implementation. =A0 =A0## U500 Platform Libraries and Drivers -### RiscVOpnesbiPlatformLib +### RiscVOpensbiPlatformLib^M =A0In order to reduce the dependencies with RISC-V OpenSBI project -(https://github.com/riscv/opensbi) and less burdens to EDK2 build process, the -implementation of RISC-V EDK2 platform is leverage platform source code from +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build process, the^M +implementation of RISC-V EDK2 platform is leveraging platform source code from^M =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is cloned= from =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 bu= ild =A0environment. @@ -89,10 +88,10 @@ This is the platform-implementation specific library which is executed in early =A0PEI phase for U500 platform initialization. =A0 =A0## U540 Platform Libraries and Drivers -### RiscVOpnesbiPlatformLib +### RiscVOpensbiPlatformLib^M =A0In order to reduce the dependencies with RISC-V OpenSBI project -(https://github.com/riscv/opensbi) and less burdens to EDK2 build process, the -implementation of RISC-V EDK2 platform is leverage platform source code from +(https://github.com/riscv/opensbi) and fewer burdens to EDK2 build process, the^M +implementation of RISC-V EDK2 platform is leveraging platform source code from^M =A0OpenSBI code tree. The "platform.c" under OpenSbiPlatformLib is cloned= from =A0RISC-V OpenSBI code tree (in EDK2 RiscVPkg) and built based on EDK2 bu= ild =A0environment.