Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

["Liming Gao" <liming.gao@intel.com>]

Laszlo:
  I also agree to handle those file type specified in build_rule.txt. 

Thanks
Liming
-----Original Message-----
From: Leif Lindholm <leif.lindholm@linaro.org> 
Sent: 2020年1月18日 3:37
To: Laszlo Ersek <lersek@redhat.com>
Cc: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

Hi Laszlo,

On Fri, Jan 17, 2020 at 19:09:22 +0100, Laszlo Ersek wrote:
> On 01/17/20 14:05, Leif Lindholm wrote:
> > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
> >> On 01/17/20 01:56, Gao, Liming wrote:
> >>> Leif:
> >>>   .act is same to .aslc. There are no cases in open source. 
> >>
> >> How about this then:
> >>
> >> *.[Aa][Cc][Tt]     diff=cpp
> >> *.[Aa][Ss][Ll][Cc] diff=cpp
> >> *.[CcHh]           diff=cpp
> >> *.[Cc][Cc]         diff=cpp
> >> *.[Cc][Pp][Pp]     diff=cpp
> > 
> > To be honest, I would rather just see them all listed explicitly.
> > The above actually adds capitalisation-combos not currently listed 
> > in build_rules.template (like .CpP).
> 
> I agree .CpP is non-intuitive, but you previously quoted .Cpp from 
> "BaseTools/Conf/build_rule.template", which is just as non-intuitive 
> to me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.)

I agree, I just included everything explicitly listed today.

> So anyway: you suggest to copy the file suffix list verbatim from the 
> [C-Code-File] and [Acpi-Table-Code-File] sections in 
> "BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and 
> *.H. Correct?

Yes please.

Best Regards,

Leif