public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Feng, Bob C" <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c
Date: Sun, 19 Jan 2020 01:47:08 +0000	[thread overview]
Message-ID: <d1467c861aff43c3b0ae3f23dea8819f@intel.com> (raw)
In-Reply-To: <20200117193706.GM20629@bivouac.eciton.net>

Laszlo:
  I also agree to handle those file type specified in build_rule.txt. 

Thanks
Liming
-----Original Message-----
From: Leif Lindholm <leif.lindholm@linaro.org> 
Sent: 2020年1月18日 3:37
To: Laszlo Ersek <lersek@redhat.com>
Cc: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io; Feng, Bob C <bob.c.feng@intel.com>
Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c

Hi Laszlo,

On Fri, Jan 17, 2020 at 19:09:22 +0100, Laszlo Ersek wrote:
> On 01/17/20 14:05, Leif Lindholm wrote:
> > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote:
> >> On 01/17/20 01:56, Gao, Liming wrote:
> >>> Leif:
> >>>   .act is same to .aslc. There are no cases in open source. 
> >>
> >> How about this then:
> >>
> >> *.[Aa][Cc][Tt]     diff=cpp
> >> *.[Aa][Ss][Ll][Cc] diff=cpp
> >> *.[CcHh]           diff=cpp
> >> *.[Cc][Cc]         diff=cpp
> >> *.[Cc][Pp][Pp]     diff=cpp
> > 
> > To be honest, I would rather just see them all listed explicitly.
> > The above actually adds capitalisation-combos not currently listed 
> > in build_rules.template (like .CpP).
> 
> I agree .CpP is non-intuitive, but you previously quoted .Cpp from 
> "BaseTools/Conf/build_rule.template", which is just as non-intuitive 
> to me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.)

I agree, I just included everything explicitly listed today.

> So anyway: you suggest to copy the file suffix list verbatim from the 
> [C-Code-File] and [Acpi-Table-Code-File] sections in 
> "BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and 
> *.H. Correct?

Yes please.

Best Regards,

Leif

  reply	other threads:[~2020-01-19  1:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 18:49 [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Laszlo Ersek
2020-01-16 21:54 ` Leif Lindholm
2020-01-17  0:22   ` Liming Gao
2020-01-17  0:51     ` Leif Lindholm
2020-01-17  0:56       ` Liming Gao
2020-01-17  8:30         ` Laszlo Ersek
2020-01-17 13:05           ` Leif Lindholm
2020-01-17 18:09             ` Laszlo Ersek
2020-01-17 19:37               ` Leif Lindholm
2020-01-19  1:47                 ` Liming Gao [this message]
2020-01-17  8:24     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1467c861aff43c3b0ae3f23dea8819f@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox