From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web12.352.1579398431606774638 for ; Sat, 18 Jan 2020 17:47:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jan 2020 17:47:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,336,1574150400"; d="scan'208";a="244066643" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 18 Jan 2020 17:47:10 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 18 Jan 2020 17:47:10 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 19 Jan 2020 09:47:08 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Sun, 19 Jan 2020 09:47:08 +0800 From: "Liming Gao" To: Leif Lindholm , Laszlo Ersek CC: "devel@edk2.groups.io" , "Feng, Bob C" Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Thread-Topic: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context" for *.h and *.c Thread-Index: AQHVzTbtuHwKNBF870Cmb8BOUKkt0KfuofIAgAAYgwCAAn9GoA== Date: Sun, 19 Jan 2020 01:47:08 +0000 Message-ID: References: <20200116184929.18020-1-lersek@redhat.com> <20200116215459.GG20629@bivouac.eciton.net> <428016653b214ab699ec2d6b4ecf2fc9@intel.com> <20200117005102.GJ20629@bivouac.eciton.net> <1529165fc50e49e3abdf073f079c1efd@intel.com> <20200117130548.GK20629@bivouac.eciton.net> <20200117193706.GM20629@bivouac.eciton.net> In-Reply-To: <20200117193706.GM20629@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable Laszlo: I also agree to handle those file type specified in build_rule.txt.=20 Thanks Liming -----Original Message----- From: Leif Lindholm =20 Sent: 2020=1B$BG/=1B(B1=1B$B7n=1B(B18=1B$BF|=1B(B 3:37 To: Laszlo Ersek Cc: Gao, Liming ; devel@edk2.groups.io; Feng, Bob C <= bob.c.feng@intel.com> Subject: Re: [PATCH] BaseTools/Conf/gitattributes: fix "--function-context"= for *.h and *.c Hi Laszlo, On Fri, Jan 17, 2020 at 19:09:22 +0100, Laszlo Ersek wrote: > On 01/17/20 14:05, Leif Lindholm wrote: > > On Fri, Jan 17, 2020 at 09:30:49 +0100, Laszlo Ersek wrote: > >> On 01/17/20 01:56, Gao, Liming wrote: > >>> Leif: > >>> .act is same to .aslc. There are no cases in open source.=20 > >> > >> How about this then: > >> > >> *.[Aa][Cc][Tt] diff=3Dcpp > >> *.[Aa][Ss][Ll][Cc] diff=3Dcpp > >> *.[CcHh] diff=3Dcpp > >> *.[Cc][Cc] diff=3Dcpp > >> *.[Cc][Pp][Pp] diff=3Dcpp > >=20 > > To be honest, I would rather just see them all listed explicitly. > > The above actually adds capitalisation-combos not currently listed=20 > > in build_rules.template (like .CpP). >=20 > I agree .CpP is non-intuitive, but you previously quoted .Cpp from=20 > "BaseTools/Conf/build_rule.template", which is just as non-intuitive=20 > to me. Who'd *capitalize* a file suffix? (I'd understand *all*-caps.) I agree, I just included everything explicitly listed today. > So anyway: you suggest to copy the file suffix list verbatim from the=20 > [C-Code-File] and [Acpi-Table-Code-File] sections in=20 > "BaseTools/Conf/build_rule.template". Plus, on top of those, *.h and=20 > *.H. Correct? Yes please. Best Regards, Leif