From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 07 May 2019 11:37:37 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A11C3002F84; Tue, 7 May 2019 18:37:37 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-152.rdu2.redhat.com [10.10.120.152]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED4D017CDF; Tue, 7 May 2019 18:37:35 +0000 (UTC) Subject: Re: [edk2-devel] [Patch v5 2/3] NetworkPkg: Add DSC/FDF include segment files to NetworkPkg. To: devel@edk2.groups.io, liming.gao@intel.com Cc: Jiaxin Wu , Ting Ye , Fu Siyuan References: <20190507142705.20092-1-liming.gao@intel.com> <20190507142705.20092-3-liming.gao@intel.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 7 May 2019 20:37:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190507142705.20092-3-liming.gao@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Tue, 07 May 2019 18:37:37 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Liming, On 05/07/19 16:27, Liming Gao wrote: > This patch provides a set of include segment files for platform owner to > easily enable/disable network stack support on their platform. > > For DSC, there are: > - a "NetworkDefines.dsc.inc" for the [Defines] section(s), > - a "NetworkLibs.dsc.inc" for the [LibraryClasses*] section(s), > - a "NetworkPcds.dsc.inc" for the [Pcds*] section(s), > - a "NetworkComponents.dsc.inc" for the [Components*] section(s). > For FDF, there is: > - a "Network.fdf.inc" for the [Fv*] section(s). > > These files can be added to the platform DSC/FDF file by using > !include NetworkPkg/xxx > where "xxx" is the *.inc file name. > > A platform DSC file can diverge from the defaults in > "NetworkDefines.dsc.inc" by setting the individual DEFINEs before > including "NetworkDefines.dsc.inc". > And, build command line ("-D FLAG=VALUE") can be used to enable or > disable related feature set, please check "NetworkDefines.dsc.inc" > for a detail description of each flag. > > The default value of these flags are: > DEFINE NETWORK_ENABLE = TRUE > DEFINE NETWORK_SNP_ENABLE = TRUE > DEFINE NETWORK_IP4_ENABLE = TRUE > DEFINE NETWORK_IP6_ENABLE = TRUE > DEFINE NETWORK_TLS_ENABLE = TRUE > DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE > DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = FALSE > DEFINE NETWORK_ISCSI_ENABLE = TRUE > DEFINE NETWORK_VLAN_ENABLE = TRUE > > Related BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1293 > > Cc: Jiaxin Wu > Cc: Ting Ye > Signed-off-by: Fu Siyuan > --- > NetworkPkg/Network.fdf.inc | 60 ++++++++++++++++++ > NetworkPkg/NetworkComponents.dsc.inc | 61 ++++++++++++++++++ > NetworkPkg/NetworkDefines.dsc.inc | 118 +++++++++++++++++++++++++++++++++++ > NetworkPkg/NetworkLibs.dsc.inc | 20 ++++++ > NetworkPkg/NetworkPcds.dsc.inc | 16 +++++ > 5 files changed, 275 insertions(+) > create mode 100644 NetworkPkg/Network.fdf.inc > create mode 100644 NetworkPkg/NetworkComponents.dsc.inc > create mode 100644 NetworkPkg/NetworkDefines.dsc.inc > create mode 100644 NetworkPkg/NetworkLibs.dsc.inc > create mode 100644 NetworkPkg/NetworkPcds.dsc.inc Before you push this patch, please also add your own "Signed-off-by" tag at the bottom of the commit message. In the end, the patch should carry both Siyuan's and your S-o-b. Thanks Laszlo