From: "Ard Biesheuvel" <ard.biesheuvel@arm.com>
To: Masahisa Kojima <masahisa.kojima@linaro.org>, devel@edk2.groups.io
Cc: leif@nuviainc.com
Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib
Date: Mon, 19 Oct 2020 10:25:11 +0200 [thread overview]
Message-ID: <d177c0d6-68dd-21ee-8e5e-31e388e5bbf2@arm.com> (raw)
In-Reply-To: <20201019080953.14833-1-masahisa.kojima@linaro.org>
On 10/19/20 10:09 AM, Masahisa Kojima wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused Developerbox platforms build to break for lack of
> an RngLib instance.
>
> Add the reference to RngLib to the DeveloperBox.dsc.inc file.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Thank you Masahisa
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com
Pushed as b0459fb6cf50..dc6a619f933f
> ---
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> index 838c55e1d1a8..ce8aac662d9b 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> @@ -103,6 +103,7 @@ [LibraryClasses]
>
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
>
prev parent reply other threads:[~2020-10-19 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 8:09 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib Masahisa Kojima
2020-10-19 8:25 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d177c0d6-68dd-21ee-8e5e-31e388e5bbf2@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox