* [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib
@ 2020-10-19 8:09 Masahisa Kojima
2020-10-19 8:25 ` Ard Biesheuvel
0 siblings, 1 reply; 2+ messages in thread
From: Masahisa Kojima @ 2020-10-19 8:09 UTC (permalink / raw)
To: devel; +Cc: ard.biesheuvel, leif, masahisa.kojima
Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
entropy in rand_pool") introduced RngLib dependency for OpensslLib
and caused Developerbox platforms build to break for lack of
an RngLib instance.
Add the reference to RngLib to the DeveloperBox.dsc.inc file.
Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
---
Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
index 838c55e1d1a8..ce8aac662d9b 100644
--- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
+++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
@@ -103,6 +103,7 @@ [LibraryClasses]
BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+ RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib
2020-10-19 8:09 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib Masahisa Kojima
@ 2020-10-19 8:25 ` Ard Biesheuvel
0 siblings, 0 replies; 2+ messages in thread
From: Ard Biesheuvel @ 2020-10-19 8:25 UTC (permalink / raw)
To: Masahisa Kojima, devel; +Cc: leif
On 10/19/20 10:09 AM, Masahisa Kojima wrote:
> Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate
> entropy in rand_pool") introduced RngLib dependency for OpensslLib
> and caused Developerbox platforms build to break for lack of
> an RngLib instance.
>
> Add the reference to RngLib to the DeveloperBox.dsc.inc file.
>
> Signed-off-by: Masahisa Kojima <masahisa.kojima@linaro.org>
Thank you Masahisa
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com
Pushed as b0459fb6cf50..dc6a619f933f
> ---
> Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> index 838c55e1d1a8..ce8aac662d9b 100644
> --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc
> @@ -103,6 +103,7 @@ [LibraryClasses]
>
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf
> TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-19 8:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-19 8:09 [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib Masahisa Kojima
2020-10-19 8:25 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox