From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.9306.1603095915367460508 for ; Mon, 19 Oct 2020 01:25:15 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D04BCD6E; Mon, 19 Oct 2020 01:25:13 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1C8173F66E; Mon, 19 Oct 2020 01:25:12 -0700 (PDT) Subject: Re: [PATCH edk2-platforms 1/1] Platform/Socionext/DeveloperBox: Fix build break due to need for RngLib To: Masahisa Kojima , devel@edk2.groups.io Cc: leif@nuviainc.com References: <20201019080953.14833-1-masahisa.kojima@linaro.org> From: "Ard Biesheuvel" Message-ID: Date: Mon, 19 Oct 2020 10:25:11 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201019080953.14833-1-masahisa.kojima@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/19/20 10:09 AM, Masahisa Kojima wrote: > Commit b5701a4c7a0f ("CryptoPkg: OpensslLib: Use RngLib to generate > entropy in rand_pool") introduced RngLib dependency for OpensslLib > and caused Developerbox platforms build to break for lack of > an RngLib instance. > > Add the reference to RngLib to the DeveloperBox.dsc.inc file. > > Signed-off-by: Masahisa Kojima Thank you Masahisa Reviewed-by: Ard Biesheuvel --- > Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > index 838c55e1d1a8..ce8aac662d9b 100644 > --- a/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > +++ b/Platform/Socionext/DeveloperBox/DeveloperBox.dsc.inc > @@ -103,6 +103,7 @@ [LibraryClasses] > > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > TpmMeasurementLib|SecurityPkg/Library/DxeTpmMeasurementLib/DxeTpmMeasurementLib.inf >