Re: [PATCH edk2-platforms 0/4] add MM based UEFI secure boot on SbsaQemu

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 12/21/20 1:53 PM, Masahisa Kojima wrote:
> This patch series implment the UEFI secure boot on SbsaQemu.
> 
> This patch requires following edk2 patches currently under review.
> - standalone MM version of VarCheckPolicyLib
> https://edk2.groups.io/g/devel/topic/patch_v2_1_1/79120932?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,79120932
> 
> - standalone MM version of NorFlash driver
> https://edk2.groups.io/g/devel/topic/patch_0_2/79058286?p=,,,20,0,0,0::recentpostdate%2Fsticky,,,20,2,0,79058286
> 
> 
> This patch series also require the following Trusted Firmware-A modification.
> https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/5797
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Graeme Gregory <graeme@nuviainc.com>
> Cc: Radoslaw Biernacki <rad@semihalf.com>
> Cc: Tanmay Jagdale <tanmay.jagdale@linaro.org>
> Cc: Shashi Mallela <shashi.mallela@linaro.org>
> 
> Masahisa Kojima (4):
>   SbsaQemu: Build infrastructure for StandaloneMm image
>   SbsaQemu: add MM based UEFI secure boot support
>   SbsaQemu: add standalone MM build instruction
>   SbsaQemu: fix typo
> 

Thanks for this - it is very useful to have Standalone MM based variable
services wired up on a ARM emulator.

The patches look ok to me, but I'd like others to chime in as well
please, either with a Reviewed-by or Tested-by (or both)

Thanks,
Ard.


>  Platform/Qemu/SbsaQemu/SbsaQemu.dsc           |  44 +++--
>  .../Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc    | 172 ++++++++++++++++++
>  Platform/Qemu/SbsaQemu/SbsaQemu.fdf           |  84 ++++++++-
>  .../Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf    |  96 ++++++++++
>  .../Library/SbsaQemuLib/SbsaQemuLib.inf       |   2 +
>  .../Library/SbsaQemuLib/SbsaQemuMem.c         |  37 +++-
>  Platform/Qemu/SbsaQemu/Readme.md              |  37 +++-
>  7 files changed, 452 insertions(+), 20 deletions(-)
>  create mode 100644 Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.dsc
>  create mode 100644 Platform/Qemu/SbsaQemu/SbsaQemuStandaloneMm.fdf
>