From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.5000.1657265491319554814 for ; Fri, 08 Jul 2022 00:31:31 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 096461063; Fri, 8 Jul 2022 00:31:31 -0700 (PDT) Received: from [10.34.100.102] (pierre123.nice.arm.com [10.34.100.102]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 03C093F792; Fri, 8 Jul 2022 00:31:29 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 09:31:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates To: Jeff Brasen , "devel@edk2.groups.io" Cc: "Sami.Mujawar@arm.com" , "Alexei.Fedorov@arm.com" References: From: "PierreGondois" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Jeff, I had some questions about the V1 at: https://edk2.groups.io/g/devel/topic/92089320#90932 https://edk2.groups.io/g/devel/topic/92089321#90933 Regards, Pierre On 7/7/22 18:59, Jeff Brasen wrote: > Pierre, > > Any thoughts on this v2 version? > > -Jeff > > >> -----Original Message----- >> From: Jeff Brasen >> Sent: Friday, July 1, 2022 10:33 AM >> To: devel@edk2.groups.io >> Cc: Pierre.Gondois@arm.com; Sami.Mujawar@arm.com; >> Alexei.Fedorov@arm.com; Jeff Brasen >> Subject: [PATCH v2 0/4] DynamicTablesPkg: Pcie generation updates >> >> Add fixes/features to dynamic PCIe support >> >> - Correct issue with translation in generated ACPI tables. >> - Allow for more than 16 controllers to be generated. >> - Allow optional use of segment number as UID for cases where ACPI path is >> needed in other places. >> - Add support for override protocol that allows platform specific modification >> of node prior to creation. >> >> Update: >> v2 - Add IsPosDecode logic to translation patch >> >> Jeff Brasen (4): >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Correct translation value >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Allow use of segment number as >> UID >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Support UID > 0xF >> DynamicTablesPkg: AcpiSsdtPcieLibArm: Add support for override >> protocol >> >> DynamicTablesPkg/DynamicTablesPkg.dec | 6 ++ >> .../Protocol/SsdtPcieOverrideProtocol.h | 63 ++++++++++++++++ >> .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 73 ++++++++++++++++--- >> .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.h | 2 +- >> .../Arm/AcpiSsdtPcieLibArm/SsdtPcieLibArm.inf | 7 ++ >> 5 files changed, 139 insertions(+), 12 deletions(-) create mode 100644 >> DynamicTablesPkg/Include/Protocol/SsdtPcieOverrideProtocol.h >> >> -- >> 2.25.1 >