From: Laszlo Ersek <lersek@redhat.com>
To: "David F." <df7729@gmail.com>,
edk2 developers list <edk2-devel@lists.01.org>
Subject: Re: stdlib broken strncasecmp.c
Date: Mon, 13 Nov 2017 14:28:31 +0100 [thread overview]
Message-ID: <d1936b74-305d-3db2-b07e-823c32572ca8@redhat.com> (raw)
In-Reply-To: <CAGRSmLsr=Z+x86eUC=2WVE4TQdzfdi1t_9mvEnc++vCsNU5JHQ@mail.gmail.com>
Hi,
On 11/10/17 20:09, David F. wrote:
> I would submit a patch but over the years of fixes and enhancements,
> they don't go anywhere. Then a couple years later someone does a
> half-baked fix and I have to run merge resolution on svn.
I've been subscribed to edk2-devel (wherever it lived whenever) since
approx. April 2012. So, I checked all my yearly archives, and the only
year where the search expression "df7729 patch" returns at least one hit
is 2013. Please don't judge the project's development process from a
four year old experience, there have been many changes.
Please consider submitting a patch with git:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
(Optional reading:
<https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers>.)
Please don't forget to CC the StdLib maintainers on your patch -- they
are listed in "Maintainers.txt".
> Anyway, the problem with that is the s1 compare to 0 should be before
> the s1++ (otherwise it matches when the s1 string is shorter than the
> s2 string).
If you don't feel like posting a patch with git, can you perhaps
register in the TianoCore Bugzilla, and file a bug report there?
https://bugzilla.tianocore.org/
Product: EDK2
Component: Code
Package: StdLib
Thanks!
Laszlo
next prev parent reply other threads:[~2017-11-13 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-10 19:09 stdlib broken strncasecmp.c David F.
2017-11-13 13:28 ` Laszlo Ersek [this message]
2017-11-13 19:58 ` Michael Zimmermann
2017-11-13 21:37 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1936b74-305d-3db2-b07e-823c32572ca8@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox