From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C488820356897 for ; Mon, 13 Nov 2017 05:24:26 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BE283C04B924; Mon, 13 Nov 2017 13:28:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-226.rdu2.redhat.com [10.10.120.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2F7B07A241; Mon, 13 Nov 2017 13:28:32 +0000 (UTC) To: "David F." , edk2 developers list References: From: Laszlo Ersek Message-ID: Date: Mon, 13 Nov 2017 14:28:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Mon, 13 Nov 2017 13:28:32 +0000 (UTC) Subject: Re: stdlib broken strncasecmp.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Nov 2017 13:24:26 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 11/10/17 20:09, David F. wrote: > I would submit a patch but over the years of fixes and enhancements, > they don't go anywhere. Then a couple years later someone does a > half-baked fix and I have to run merge resolution on svn. I've been subscribed to edk2-devel (wherever it lived whenever) since approx. April 2012. So, I checked all my yearly archives, and the only year where the search expression "df7729 patch" returns at least one hit is 2013. Please don't judge the project's development process from a four year old experience, there have been many changes. Please consider submitting a patch with git: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process (Optional reading: .) Please don't forget to CC the StdLib maintainers on your patch -- they are listed in "Maintainers.txt". > Anyway, the problem with that is the s1 compare to 0 should be before > the s1++ (otherwise it matches when the s1 string is shorter than the > s2 string). If you don't feel like posting a patch with git, can you perhaps register in the TianoCore Bugzilla, and file a bug report there? https://bugzilla.tianocore.org/ Product: EDK2 Component: Code Package: StdLib Thanks! Laszlo