From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Andrew Fish <afish@apple.com>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Liming Gao <gaoliming@byosoft.com.cn>
Cc: "Feng, Bob C" <bob.c.feng@intel.com>,
Joey Vagedes <joey.vagedes@gmail.com>,
Rebecca Cran <rebecca@bsdio.com>,
Sean Brogan <sean.brogan@microsoft.com>,
"Chen, Christine" <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
Date: Mon, 3 Jun 2024 08:17:11 -0400 [thread overview]
Message-ID: <d19d062f-fd7b-45ca-80ed-ef1a3383eebc@linux.microsoft.com> (raw)
In-Reply-To: <0700423e-bf22-42bb-a593-5202c5f649ac@linux.microsoft.com>
As a follow up, I created the following PR to specify the exact version
of queries to use for a given CodeQL CLI release. Now that both are
explicitly specified (the CLI and the query version), there should not
be any mismatch in the future where we're using an older CodeQL CLI
against the latest (incompatible) queries.
https://github.com/tianocore/edk2/pull/5720
On 5/20/2024 9:40 PM, Michael Kubacki wrote:
> Just wanted to send a reminder that I recommend
> https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for
> those that are currently trying to test changes.
>
> Thanks,
> Michael
>
> On 5/17/2024 8:10 PM, Kinney, Michael D wrote:
>> Approved. I agree there is no impact to FW.
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: Michael Kubacki <mikuback@linux.microsoft.com>
>>> Sent: Friday, May 17, 2024 4:28 PM
>>> To: Kinney, Michael D <michael.d.kinney@intel.com>;
>>> devel@edk2.groups.io;
>>> Andrew Fish <afish@apple.com>; Leif Lindholm
>>> <quic_llindhol@quicinc.com>;
>>> Liming Gao <gaoliming@byosoft.com.cn>
>>> Cc: Feng, Bob C <bob.c.feng@intel.com>; Joey Vagedes
>>> <joey.vagedes@gmail.com>; Rebecca Cran <rebecca@bsdio.com>; Sean Brogan
>>> <sean.brogan@microsoft.com>; Chen, Christine <yuwei.chen@intel.com>
>>> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3
>>>
>>> Forgot about the hard freeze.
>>>
>>> Added remaining stewards to consider merging this. It has no impact on
>>> firmware but is needed to unblock an immediate issue in CI where the
>>> CodeQL queries being fetched are newer and incompatible with the CodeQL
>>> CLI being used.
>>>
>>> As I mentioned in the release notes, I will follow up in the future for
>>> a change that should be able to lock the CodeQL query versions against
>>> the CLI version.
>>>
>>> Thanks,
>>> Michael
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119427): https://edk2.groups.io/g/devel/message/119427
Mute This Topic: https://groups.io/mt/106161774/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-06-03 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-17 21:09 [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 Michael Kubacki
2024-05-17 21:31 ` Michael D Kinney
2024-05-17 22:06 ` Joey Vagedes via groups.io
2024-05-17 22:31 ` Michael Kubacki
2024-05-17 23:20 ` Michael Kubacki
2024-05-17 23:27 ` Michael Kubacki
2024-05-18 0:10 ` Michael D Kinney
2024-05-21 1:40 ` Michael Kubacki
2024-05-21 2:24 ` Michael D Kinney
2024-06-03 12:17 ` Michael Kubacki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d19d062f-fd7b-45ca-80ed-ef1a3383eebc@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox