From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id B40C6AC124B for ; Mon, 3 Jun 2024 12:17:15 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=o8bFiKurI2NfQKM3ODDmh1BBDAs1AEKe4CV+/MeMoT8=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1717417035; v=1; b=wRAs9hrnBiac0EIgQK9Duwkx5fl3MD1C+xk5/wVrEnaD5RfBC8bOCBb4UijYETpPyK41OWNu VuSohy3FIhRNtLNdLHTIf0A/KE+OHe4lCQZfVA8mlGOKpTYhpIA/v8Uwb5VI+YRrgBhHbRBMBXv byBaa/1CDTxdLA3sdXe/xWf5Wdah2Qp6ddOWkfRafvrAaVVnt0EWPwo67cHILSQKrb9YkeVh4Gp NdzMNbLw1oYzUuG96Tb6i9jqD5t8tk9jMKdMlG9LiVWSooAyc9OuBi2PXFRutWCHUSFQ2bihtfD QYLDtsQfys28MZh2FPn5wE2tBE/W/i+TuBXwBUrdZ5Bog== X-Received: by 127.0.0.2 with SMTP id qk1RYY7687511xJVMEI6zEY3; Mon, 03 Jun 2024 05:17:14 -0700 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.81829.1717417033649071479 for ; Mon, 03 Jun 2024 05:17:13 -0700 X-Received: from [10.6.0.181] (unknown [20.39.63.14]) by linux.microsoft.com (Postfix) with ESMTPSA id 732EA20B915A; Mon, 3 Jun 2024 05:17:12 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 732EA20B915A Message-ID: Date: Mon, 3 Jun 2024 08:17:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 From: "Michael Kubacki" To: "Kinney, Michael D" , "devel@edk2.groups.io" , Andrew Fish , Leif Lindholm , Liming Gao Cc: "Feng, Bob C" , Joey Vagedes , Rebecca Cran , Sean Brogan , "Chen, Christine" References: <20240517210902.1510-1-mikuback@linux.microsoft.com> <8354dafc-6c4c-4981-9561-bd46f5b6b14d@linux.microsoft.com> <78674f4f-0923-4117-bfa8-61953930c4cf@linux.microsoft.com> <0700423e-bf22-42bb-a593-5202c5f649ac@linux.microsoft.com> In-Reply-To: <0700423e-bf22-42bb-a593-5202c5f649ac@linux.microsoft.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 03 Jun 2024 05:17:13 -0700 Resent-From: mikuback@linux.microsoft.com Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: H7cC9u07JlLeQ2gknMv5DdVlx7686176AA= Content-Language: en-CA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=wRAs9hrn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io As a follow up, I created the following PR to specify the exact version=20 of queries to use for a given CodeQL CLI release. Now that both are=20 explicitly specified (the CLI and the query version), there should not=20 be any mismatch in the future where we're using an older CodeQL CLI=20 against the latest (incompatible) queries. https://github.com/tianocore/edk2/pull/5720 On 5/20/2024 9:40 PM, Michael Kubacki wrote: > Just wanted to send a reminder that I recommend=20 > https://github.com/tianocore/edk2/pull/5667 be merged to unblock CI for= =20 > those that are currently trying to test changes. >=20 > Thanks, > Michael >=20 > On 5/17/2024 8:10 PM, Kinney, Michael D wrote: >> Approved. I agree there is no impact to FW. >> >> Mike >> >>> -----Original Message----- >>> From: Michael Kubacki >>> Sent: Friday, May 17, 2024 4:28 PM >>> To: Kinney, Michael D ;=20 >>> devel@edk2.groups.io; >>> Andrew Fish ; Leif Lindholm=20 >>> ; >>> Liming Gao >>> Cc: Feng, Bob C ; Joey Vagedes >>> ; Rebecca Cran ; Sean Brogan >>> ; Chen, Christine >>> Subject: Re: [PATCH v1 1/1] CodeQL: Update from 2.16.1 to 2.17.3 >>> >>> Forgot about the hard freeze. >>> >>> Added remaining stewards to consider merging this. It has no impact on >>> firmware but is needed to unblock an immediate issue in CI where the >>> CodeQL queries being fetched are newer and incompatible with the CodeQL >>> CLI being used. >>> >>> As I mentioned in the release notes, I will follow up in the future for >>> a change that should be able to lock the CodeQL query versions against >>> the CLI version. >>> >>> Thanks, >>> Michael -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119427): https://edk2.groups.io/g/devel/message/119427 Mute This Topic: https://groups.io/mt/106161774/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-