From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: julien.grall@arm.com) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by groups.io with SMTP; Wed, 18 Sep 2019 03:30:52 -0700 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D405D337; Wed, 18 Sep 2019 03:30:51 -0700 (PDT) Received: from [10.1.196.50] (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BE883F59C; Wed, 18 Sep 2019 03:30:51 -0700 (PDT) Subject: Re: [PATCH 22/35] OvmfPkg/XenBusDxe: fix UninstallMultipleProtocolInterfaces() call To: Laszlo Ersek , edk2-devel-groups-io Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-23-lersek@redhat.com> From: "Julien Grall" Message-ID: Date: Wed, 18 Sep 2019 11:30:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-23-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 17/09/2019 20:49, Laszlo Ersek wrote: > Unlike the InstallMultipleProtocolInterfaces() boot service, which takes > an (EFI_HANDLE*) as first parameter, the > UninstallMultipleProtocolInterfaces() boot service takes an EFI_HANDLE as > first parameter. > > This is an actual bug. It must have remained hidden until now because it's > on an error path. Fix the UninstallMultipleProtocolInterfaces() call. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Signed-off-by: Laszlo Ersek Reviewed-by: Julien Grall Cheers, -- Julien Grall