public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <quic_rcran@quicinc.com>
To: <devel@edk2.groups.io>, <kraxel@redhat.com>,
	Rebecca Cran <quic_rcran@quicinc.com>
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Julien Grall <julien@xen.org>,
	Oliver Steffen <osteffen@redhat.com>,
	Pawel Polawski <ppolawsk@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Anthony Perard <anthony.perard@citrix.com>,
	Jiewen Yao <jiewen.yao@intel.com>
Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString
Date: Tue, 11 Oct 2022 09:34:17 -0600	[thread overview]
Message-ID: <d1bb89f0-688c-9d7f-011d-d614754034e5@quicinc.com> (raw)
In-Reply-To: <20221011075952.r5yxm6s2hukzapnz@sirius.home.kraxel.org>

On 10/11/22 01:59, Gerd Hoffmann wrote:
>
> Next question is how to set them.  I think it makes sense to have some
> sensible defaults, but still allow to override them.  MdeModulePkg
> defines them to empty strings (except vendor).  Should we set them to
> the most recent stable tag instead, i.e. something like this?
>
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""|VOID*|0x00010052
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"edk2-stable202208"|VOID*|0x00010052
>
> -  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L""|VOID*|0x00010053
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L"26/08/2022"|VOID*|0x00010053
>
> When doing that:  Can this be overridden on the command line?  Trying to
> do so using 'build --pcd PcdFirmwareVersionString=Test' didn't work for
> me, the string wasn't translated to unicode ...
>
> I've noticed ArmVirtPkg/ArmVirtXen.dsc has this line ...
>
>    gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)"
>
> ... which allows to override using 'build -D FIRMWARE_VER=Test'.
> Unicode encoding works that way, but it would also override the
> MdeModulePkg default (if we add one).

The method I've used in the past is to override strings on the command 
line, just like ArmVirtXen.dsc does, and I like that approach.
I like the idea of defaulting to the stable tag, though we could perhaps 
shorten it to "202208" instead? I'm fairly sure the release date should 
be in MM/DD/YYYY format for e.g. SMBIOS compatibility (sigh) - though 
I've just realized that for SMBIOS we ignore that PCD and just use 
__DATE__ and __TIME__.

-- 
Rebecca Cran

  reply	other threads:[~2022-10-11 15:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 14:42 [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString Gerd Hoffmann
2022-10-10 16:27 ` [edk2-devel] " Rebecca Cran
2022-10-11  7:59   ` Gerd Hoffmann
2022-10-11 15:34     ` Rebecca Cran [this message]
2022-10-12  8:52       ` Gerd Hoffmann
2022-10-24 14:03         ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d1bb89f0-688c-9d7f-011d-d614754034e5@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox