From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web11.8976.1665502461039318676 for ; Tue, 11 Oct 2022 08:34:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=LQkkd6zF; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 205.220.168.131, mailfrom: quic_rcran@quicinc.com) Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 29BC12kN026264; Tue, 11 Oct 2022 15:34:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=KUGc1rbN8OGLEAUYzhXtL13McAKG0aBaexLI9Xb2czA=; b=LQkkd6zF/ScIhCWROL50lWrF01l2hB7RfHsfDrOGgNQQ6b+f5IhSe2tY0H0exGL85b68 GD9RV/rC6kuC0mQKkaibkNUMb1Oe72RAli4w9oGkTf2Oy+E3q9HTttqIN9O4X8aKO/6p 4kW6ZfOj/9dME++6PqE7ouEON0X9qro4wbY57IIwYDCvkf30DzXPEyX/6XxkRrdCVg9+ qju/+xGVkQPzv1tieHDzYkfo02ekKnFVM6Nz+SPEEMJ6/WNfbsgqIlx99Fhq8mMTRQ3l v4hYsWqPuaZnvyfJ7tPNrUmp5w2bVilb4dom6aqdxncdvgp7zi87GAf6AM5ICvidyPiK bw== Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3k4rx2k7yj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Oct 2022 15:34:20 +0000 Received: from pps.filterd (NASANPPMTA03.qualcomm.com [127.0.0.1]) by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 29BFXRNZ007753; Tue, 11 Oct 2022 15:34:19 GMT Received: from pps.reinject (localhost [127.0.0.1]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTPS id 3k3jrhjtw7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Oct 2022 15:34:19 +0000 Received: from NASANPPMTA03.qualcomm.com (NASANPPMTA03.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 29BFYJCh008723; Tue, 11 Oct 2022 15:34:19 GMT Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA03.qualcomm.com (PPS) with ESMTPS id 29BFYJtO008720 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Oct 2022 15:34:19 +0000 Received: from [10.110.88.158] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 11 Oct 2022 08:34:18 -0700 Message-ID: Date: Tue, 11 Oct 2022 09:34:17 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg/SmbiosPlatformDxe: use PcdFirmwareVersionString To: , , Rebecca Cran CC: Jordan Justen , Julien Grall , Oliver Steffen , Pawel Polawski , Ard Biesheuvel , Anthony Perard , Jiewen Yao References: <20221010144213.1470478-1-kraxel@redhat.com> <8fde917f-c932-0e0c-499f-bbe9daa95ac9@quicinc.com> <20221011075952.r5yxm6s2hukzapnz@sirius.home.kraxel.org> From: "Rebecca Cran" In-Reply-To: <20221011075952.r5yxm6s2hukzapnz@sirius.home.kraxel.org> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: i_lWRc9-Udxtdqxzm9L2lRbB_3EEEhy5 X-Proofpoint-ORIG-GUID: i_lWRc9-Udxtdqxzm9L2lRbB_3EEEhy5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-10-11_08,2022-10-11_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 mlxlogscore=999 impostorscore=0 malwarescore=0 lowpriorityscore=0 mlxscore=0 phishscore=0 suspectscore=0 bulkscore=0 spamscore=0 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2210110089 Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit On 10/11/22 01:59, Gerd Hoffmann wrote: > > Next question is how to set them. I think it makes sense to have some > sensible defaults, but still allow to override them. MdeModulePkg > defines them to empty strings (except vendor). Should we set them to > the most recent stable tag instead, i.e. something like this? > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L""|VOID*|0x00010052 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"edk2-stable202208"|VOID*|0x00010052 > > - gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L""|VOID*|0x00010053 > + gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareReleaseDateString|L"26/08/2022"|VOID*|0x00010053 > > When doing that: Can this be overridden on the command line? Trying to > do so using 'build --pcd PcdFirmwareVersionString=Test' didn't work for > me, the string wasn't translated to unicode ... > > I've noticed ArmVirtPkg/ArmVirtXen.dsc has this line ... > > gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString|L"$(FIRMWARE_VER)" > > ... which allows to override using 'build -D FIRMWARE_VER=Test'. > Unicode encoding works that way, but it would also override the > MdeModulePkg default (if we add one). The method I've used in the past is to override strings on the command line, just like ArmVirtXen.dsc does, and I like that approach. I like the idea of defaulting to the stable tag, though we could perhaps shorten it to "202208" instead? I'm fairly sure the release date should be in MM/DD/YYYY format for e.g. SMBIOS compatibility (sigh) - though I've just realized that for SMBIOS we ignore that PCD and just use __DATE__ and __TIME__. -- Rebecca Cran