From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, dwmw2@infradead.org
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [edk2-devel] [PATCH] ArmVirtPkg/XenAcpiPlatformDxe: Install FACS table from DT
Date: Sun, 25 Feb 2024 21:51:50 +0100 [thread overview]
Message-ID: <d1d28bd7-61f4-f79a-f38b-cc91595cb066@redhat.com> (raw)
In-Reply-To: <881dd0a2558ecbdfa02c844722d8a1103ab97ab3.camel@infradead.org>
On 2/13/24 11:50, David Woodhouse wrote:
> From: David Woodhouse <dwmw@amazon.co.uk>
>
> The FACS may still exist when the reduced hardware flag is set in FADT;
> it is optional. Since it contains the hardware signature field which
> indicates that a hibernated system should boot cleanly instead of
> attempting to resume, a platform may choose to expose it. Propagate it
> correctly.
>
> Also avoid a NULL pointer dereference if the platform doesn't provide
> a DSDT.
>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
> ---
> .../XenAcpiPlatformDxe/XenAcpiPlatformDxe.c | 37 +++++++++++++++----
> 1 file changed, 29 insertions(+), 8 deletions(-)
Merged as commit ba96acd963e7, via
<https://github.com/tianocore/edk2/pull/5407>. (I needed to "uncrustify"
the code first.)
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115935): https://edk2.groups.io/g/devel/message/115935
Mute This Topic: https://groups.io/mt/104329932/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-02-25 20:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 10:50 [edk2-devel] [PATCH] ArmVirtPkg/XenAcpiPlatformDxe: Install FACS table from DT David Woodhouse
2024-02-14 10:36 ` Laszlo Ersek
2024-02-25 20:51 ` Laszlo Ersek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1d28bd7-61f4-f79a-f38b-cc91595cb066@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox