From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web12.7226.1580314114687774635
 for <devel@edk2.groups.io>;
 Wed, 29 Jan 2020 08:08:34 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=NCu6SN4g;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1580314113;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FVuvRoAy8xoENx5N43bQmC4vcpEQFqzKqPvcVa0lw74=;
	b=NCu6SN4gDKvRTIJNzA4R/I1Z30ADSc/FJyO/OiHm6CRC172YlgKgpS5TdDMHTO7843YX9t
	dHBaqZyMWeqBTFPYq8s37E1i4VkOfRX/LHz7Y11inUz77mQbm7QGjnr+eqtJWm1TobWziA
	L/2XLSfIIhLndkN0mO7wWgijxQUwTbA=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-50-s9lFZGMxPDKD8_Bk0unEHw-1; Wed, 29 Jan 2020 11:08:29 -0500
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3621113EF;
	Wed, 29 Jan 2020 16:08:28 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-32.ams2.redhat.com [10.36.116.32])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 1365D9B900;
	Wed, 29 Jan 2020 16:08:24 +0000 (UTC)
Subject: Re: [PATCH 1/5] OvmfPkg/XenResetVector: Silent a warning from nasm
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>, xen-devel@lists.xenproject.org,
 Liming Gao <liming.gao@intel.com>, Jordan Justen
 <jordan.l.justen@intel.com>, Julien Grall <julien@xen.org>
References: <20200129121235.1814563-1-anthony.perard@citrix.com>
 <20200129121235.1814563-2-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <d1f6bfeb-6cf8-649e-baa0-b5e5c27f42e7@redhat.com>
Date: Wed, 29 Jan 2020 17:08:20 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200129121235.1814563-2-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-MC-Unique: s9lFZGMxPDKD8_Bk0unEHw-1
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 01/29/20 13:12, Anthony PERARD wrote:
> To avoid nasm generating a warning, replace the macro by the value
> expected to be stored in eax.
>   Ia32/XenPVHMain.asm:76: warning: dword data exceeds bounds
> 
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm b/OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm
> index 2df0f12e18cb..c761e9d30729 100644
> --- a/OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm
> +++ b/OvmfPkg/XenResetVector/Ia32/XenPVHMain.asm
> @@ -73,7 +73,7 @@ xenPVHMain:
>      ;
>      ; parameter for Flat32SearchForBfvBase
>      ;
> -    mov     eax, ADDR_OF(fourGigabytes)
> +    mov     eax, 0   ; ADDR_OF(fourGigabytes)
>      add     eax, edx ; add delta
>  
>      ;
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>