From: Laszlo Ersek <lersek@redhat.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"marcandre.lureau@redhat.com" <marcandre.lureau@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations
Date: Wed, 7 Mar 2018 21:50:34 +0100 [thread overview]
Message-ID: <d20062be-fc5b-5703-4229-ef1fbae75139@redhat.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB0483103BA47A81@shsmsx102.ccr.corp.intel.com>
On 03/07/18 10:42, Zeng, Star wrote:
> Hi Laszlo,
>
> Good analysis.
>
> Yes, the SupportedHashMask field in HashInterfaceHob will have stale value, but that does not impact the functionality since the code have.
> So the patch could fix the problem.
>
> HashLibBaseCryptoRouterPeiConstructor():
> Status = PcdSet32S (PcdTcg2HashAlgorithmBitmap, 0);
>
> RegisterHashInterfaceLib():
> HashInterfaceHob->SupportedHashMask = PcdGet32 (PcdTcg2HashAlgorithmBitmap) | HashMask;
>
> HashStart()/HashUpdate()/HashCompleteAndExtend()/HashAndExtend():
> if (HashInterfaceHob->HashInterfaceCount == 0) {
> return EFI_UNSUPPORTED;
> }
>
> RegisterHashInterfaceLib():
> if (HashInterfaceHob->HashInterfaceCount >= HASH_COUNT) {
> return EFI_OUT_OF_RESOURCES;
> }
Ugh, this is a bit too complex for me to digest right now, but I'll
trust you if you say the value doesn't matter :)
> As I know, Chao has helped push the patch.
Yes, that's correct, it's commit 4cc2b63bd829 ("SecurityPkg: only clear
HashInterface information", 2018-03-07).
> But I am fine with keeping this patch or continue refining the code. :)
I would slightly prefer clearing the SupportedHashMask field as well (or
adding a comment explaining why it's not necessary), because then the
uninitiated reader, like me, wouldn't have to ask themselves why the
field isn't being cleared :)
But, given your response, I don't feel strongly about it any longer;
I'll leave it up to Marc-André.
(Also, if we have to choose between extending the ZeroMem() and writing
the comment, I think the former is easier :) I could write that too, but
I couldn't write the comment.)
> Is it working with " ZeroMem (HashInterfaceHob, sizeof (*HashInterfaceHob) - sizeof (EFI_GUID)) " if to refine the code?
I'll skip this question based on your later followup.
Thanks!
Laszlo
next prev parent reply other threads:[~2018-03-07 20:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 20:27 [PATCH 1/1] RFC: SecurityPkg: only clear HashInterface informations marcandre.lureau
2018-03-07 0:40 ` Zeng, Star
2018-03-07 0:40 ` Yao, Jiewen
2018-03-07 2:03 ` Zhang, Chao B
2018-03-07 9:06 ` Laszlo Ersek
2018-03-07 9:42 ` Zeng, Star
2018-03-07 15:05 ` Zeng, Star
2018-03-07 20:50 ` Laszlo Ersek [this message]
2018-03-07 10:53 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20062be-fc5b-5703-4229-ef1fbae75139@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox