From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web10.37.1594656828316771132 for ; Mon, 13 Jul 2020 09:13:48 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Wueq93+S; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594656827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SalAOeTK8XPf34yBC5eI0NNO3Vnc7XljgA8MLNT+qxY=; b=Wueq93+SKeeSuryJJR5bdzJDGwwJT6h6D3ak1EjfWAuCAozQzWoqQ9IULwdexvpyQ98PVC m59AlM+dhfNGwFfKtQEVr5WFS9FUPvfcOKE7Gplv2s3NqUpGYv3UdKrscIQ3fVxCVmqNKb TeZKv0by8lktBCpKhgP7cos23XKf1aY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-64-b_5KqTcgPP2SBshJk0YLaQ-1; Mon, 13 Jul 2020 12:13:43 -0400 X-MC-Unique: b_5KqTcgPP2SBshJk0YLaQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A2DDE192FDA0; Mon, 13 Jul 2020 16:13:16 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-183.ams2.redhat.com [10.36.114.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id BC3E81CA; Mon, 13 Jul 2020 16:13:14 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH V3 3/4] UefiCpuPkg: Update EFI_MEMORY_CACHETYPE_MASK definition To: ray.ni@intel.com, Eric Dong Cc: devel@edk2.groups.io, oleksiyy@ami.com, liming.gao@intel.com, michael.d.kinney@intel.com, dandan.bi@intel.com, rahul1.kumar@intel.com, Felixp@ami.com References: <20200702205039.52400-1-oleksiyy@ami.com> <20200702205039.52400-4-oleksiyy@ami.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 13 Jul 2020 18:13:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200702205039.52400-4-oleksiyy@ami.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Eric, Ray, can you please ACK this patch? Thanks Laszlo On 07/02/20 22:50, Oleksiy Yakovlev wrote: > Add EFI_MEMORY_WP attribute to > EFI_MEMORY_CACHETYPE_MASK definition. > > Signed-off-by: Oleksiy Yakovlev > --- > UefiCpuPkg/CpuDxe/CpuDxe.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.h b/UefiCpuPkg/CpuDxe/CpuDxe.h > index 9299eaa..b30a896 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.h > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.h > @@ -43,7 +43,8 @@ > EFI_MEMORY_WC | \ > EFI_MEMORY_WT | \ > EFI_MEMORY_WB | \ > - EFI_MEMORY_UCE \ > + EFI_MEMORY_UCE | \ > + EFI_MEMORY_WP \ > ) > > #define EFI_MEMORY_PAGETYPE_MASK (EFI_MEMORY_RP | \ >