From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, gua.guo@intel.com
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Sean Brogan <sean.brogan@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure
Date: Wed, 26 Apr 2023 21:20:11 -0400 [thread overview]
Message-ID: <d237388f-9c0e-2639-0856-67e8aa612625@linux.microsoft.com> (raw)
In-Reply-To: <20230427003416.315-1-gua.guo@intel.com>
Reviewed-by: Michael Kubacki <michael.kubacki@microsoft.com>
On 4/26/2023 8:34 PM, Guo, Gua wrote:
> From: Gua Guo <gua.guo@intel.com>
>
> If code coverage exist failure, CI/CD need to catch it
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Kubacki <mikuback@linux.microsoft.com>
> Signed-off-by: Gua Guo <gua.guo@intel.com>
> ---
> .../HostBasedUnitTestRunner/HostBasedUnitTestRunner.py | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> index a384b55629..d993de9412 100644
> --- a/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> +++ b/BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py
> @@ -130,9 +130,13 @@ class HostBasedUnitTestRunner(IUefiBuildPlugin):
>
>
> if thebuilder.env.GetValue("CODE_COVERAGE") != "FALSE":
>
> if thebuilder.env.GetValue("TOOL_CHAIN_TAG") == "GCC5":
>
> - self.gen_code_coverage_gcc(thebuilder)
>
> + ret = self.gen_code_coverage_gcc(thebuilder)
>
> + if ret != 0:
>
> + failure_count += 1
>
> elif thebuilder.env.GetValue("TOOL_CHAIN_TAG").startswith ("VS"):
>
> - self.gen_code_coverage_msvc(thebuilder)
>
> + ret = self.gen_code_coverage_msvc(thebuilder)
>
> + if ret != 0:
>
> + failure_count += 1
>
> else:
>
> logging.info("Skipping code coverage. Currently, support GCC and MSVC compiler.")
>
>
>
prev parent reply other threads:[~2023-04-27 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 0:34 [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Guo, Gua
2023-04-27 0:34 ` [PATCH v2 2/2] .azurepipelines: Choose container that have installed lcov Guo, Gua
2023-04-27 0:52 ` Michael D Kinney
2023-04-27 1:23 ` Guo, Gua
2023-04-27 1:28 ` Michael Kubacki
2023-04-27 1:38 ` [edk2-devel] " Chris Fernald
2023-05-03 11:54 ` Oliver Steffen
2023-04-27 0:50 ` [PATCH v2 1/2] BaseTools/Plugin: Report error if code coverage failure Michael D Kinney
2023-04-27 1:20 ` Michael Kubacki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d237388f-9c0e-2639-0856-67e8aa612625@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox