From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E26D0202E5CF9 for ; Wed, 18 Oct 2017 02:33:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30B4A356D0; Wed, 18 Oct 2017 09:37:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 30B4A356D0 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-113.rdu2.redhat.com [10.10.120.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 58F0570BD4; Wed, 18 Oct 2017 09:37:14 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Thomas Huth , Liming Gao References: <20171017211234.13730-1-lersek@redhat.com> Message-ID: Date: Wed, 18 Oct 2017 11:37:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171017211234.13730-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 18 Oct 2017 09:37:15 +0000 (UTC) Subject: Re: [PATCH] BaseTools/BuildEnv: override "set -C" (noclobber) in sourcing shell env X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Oct 2017 09:33:39 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/17/17 23:12, Laszlo Ersek wrote: > The BuildEnv utility is sourced (executed by the user's interactive shell) > when the user sets up the build session. Some users like to set -C > (noclobber) for some additional safety in their shells, which trips up > BuildEnv. Update the redirection operator so that it overrides noclobber. > > Cc: Liming Gao > Cc: Thomas Huth > Cc: Yonghong Zhu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek > --- > > Notes: > Repo: https://github.com/lersek/edk2.git > Branch: buildenv_clobber > > BaseTools/BuildEnv | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv > index f74881111c8e..ff0c5115a5e1 100755 > --- a/BaseTools/BuildEnv > +++ b/BaseTools/BuildEnv > @@ -90,7 +90,7 @@ StoreCurrentConfiguration() { > # > OUTPUT_FILE=$CONF_PATH/BuildEnv.sh > #echo Storing current configuration into $OUTPUT_FILE > - echo "# Auto-generated by ${BASH_SOURCE[0]}" > $OUTPUT_FILE > + echo "# Auto-generated by ${BASH_SOURCE[0]}" >| $OUTPUT_FILE > GenerateShellCodeToSetVariable WORKSPACE $OUTPUT_FILE > GenerateShellCodeToSetVariable EDK_TOOLS_PATH $OUTPUT_FILE > GenerateShellCodeToUpdatePath $OUTPUT_FILE > Thank you all for the reviews, patch pushed as commit 4bbf39632c84. Laszlo