From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-002e3701.pphosted.com (mx0b-002e3701.pphosted.com [148.163.143.35]) by mx.groups.io with SMTP id smtpd.web11.2126.1632872499506154272 for ; Tue, 28 Sep 2021 16:41:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@hpe.com header.s=pps0720 header.b=KVqH+euh; spf=temperror, err=temporary DNS error (domain: hpe.com, ip: 148.163.143.35, mailfrom: prvs=090543438a=daniel.schaefer@hpe.com) Received: from pps.filterd (m0150245.ppops.net [127.0.0.1]) by mx0b-002e3701.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18SFncMj016244; Tue, 28 Sep 2021 23:41:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hpe.com; h=message-id : date : subject : from : to : cc : reply-to : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pps0720; bh=A6q4HAD0YWI50QN6HkSo3lXhU+wsOku8sAnXZB6uivw=; b=KVqH+euh66g8w+whownat+/f5W1tIm1Jp/idh9kg361D8Pqq+tuqlbRsCwUE/73CLCNZ bFa9aC1/DZ8YZx04mgPyM6Xve+MeIT/HeoYuyMwBMUO8kktqWBymMolfYpglfhpvIb7+ zruuA76H1vOfaJNxTs7HYW9BTFa+GX5toTetUqO00hMYfSx8LfwCiLPtf77quuzu0kTB MZLAk9qaVAvdYl8+Axs5eBoP+1F+jPV3iHcHoxIIJ8/AZR353oCZMmly/f44fkdQlSKP lkc9PWD2lZga9GSGrFOPPGVY4XS1RBHG2G/fjMaX6q96+cJ19TPYtqXoYjZdaMGQNV93 cA== Received: from g2t2353.austin.hpe.com (g2t2353.austin.hpe.com [15.233.44.26]) by mx0b-002e3701.pphosted.com with ESMTP id 3bbv8h8n6y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 28 Sep 2021 23:41:35 +0000 Received: from G4W9119.americas.hpqcorp.net (exchangepmrr1.us.hpecorp.net [16.210.20.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by g2t2353.austin.hpe.com (Postfix) with ESMTPS id 9791777; Tue, 28 Sep 2021 23:41:34 +0000 (UTC) Received: from G9W8453.americas.hpqcorp.net (2002:10d8:a0d3::10d8:a0d3) by G4W9119.americas.hpqcorp.net (2002:10d2:14d6::10d2:14d6) with Microsoft SMTP Server (TLS) id 15.0.1497.23; Tue, 28 Sep 2021 23:41:34 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.241.52.13) by G9W8453.americas.hpqcorp.net (16.216.160.211) with Microsoft SMTP Server (TLS) id 15.0.1497.23 via Frontend Transport; Tue, 28 Sep 2021 23:41:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H78qivwtVf3CKoA/Gpdsn8QN2vq93AWcenRmJYg7JaOWiSMIQDbDreH7tH2DPKaPwLChWzHUxj3gpcxLS8Xz/BuCwUUm2sYij9xJcaCKe9AmD+XaRKMBywNS3Ve4ua9wzLUkbCTsjzLKKdWS+kaoLBFNeuCNDO2V/XaNpFDukA0N0BUhTQL/0bV9vopjbtn8z0d/YsF5L4UYXpTfCrCyWaoR15lmO88p8c/inEi5LwTFlCjtEpAT2I674EYQf7awh21XxXb9aqyun5x3QnKCMvdv5TGEiV7xyrooP4V39WpxNBBRfDdUCWp2hq4JyBEtxMFaH/pemOxMFgkNMHUZRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QM64NHBAY8XuhNMgxqXshHt96lhiZe4/ZYMgA3xo9UY=; b=WArZ8ooAZwUThE8B6dAeTov+woEBToIZ2qzaGFkH85HsqoW0ZoFBeRCgDsSFGhQvP/bVKvjEt99CUgHijEk+SzS1T5Nwjn84Sb96LzhEAAv7kOJUnbpQzaJve79dczDEwq4ARsbTRfc4p66kNxYNCAV8OC6kYinmDR2jrr0pc3E5L/sll8UtWUugDuSbq+cg9sS+50XwUbdXI+Wui+g6vUX0MeiJtQmKarLBdCUf13T4Um2o9a9VieSta40RsvW6CMa9Z/KKtuzTKiCp1xTK2YbwOxpP4Do5oZsqUmnVeEEjTiM5IQ8WVXSLe3f7hXtZ8DxwkbW3wMfRajYw4FvYAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=hpe.com; dmarc=pass action=none header.from=hpe.com; dkim=pass header.d=hpe.com; arc=none Authentication-Results: hpe.com; dkim=none (message not signed) header.d=none;hpe.com; dmarc=none action=none header.from=hpe.com; Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) by DF4PR8401MB1035.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.13; Tue, 28 Sep 2021 23:41:32 +0000 Received: from DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469]) by DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM ([fe80::597f:4786:f1d6:8469%3]) with mapi id 15.20.4544.021; Tue, 28 Sep 2021 23:41:32 +0000 Message-ID: Date: Wed, 29 Sep 2021 07:41:22 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [edk2-devel] [PATCH V2 4/9] ArmVirtPkg/FdtPciPcdProducerLib: Relocate PciPcdProducerLib to OvmfPkg From: "Daniel Schaefer" To: Abner Chang , CC: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Sunil V L Reply-To: , References: <20210928083107.7418-1-abner.chang@hpe.com> <20210928083107.7418-5-abner.chang@hpe.com> <16A91FA9AD0B84BA.7073@groups.io> In-Reply-To: <16A91FA9AD0B84BA.7073@groups.io> X-ClientProxiedBy: HK2PR02CA0203.apcprd02.prod.outlook.com (2603:1096:201:20::15) To DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:760f::13) Received: from [192.168.100.176] (123.193.59.220) by HK2PR02CA0203.apcprd02.prod.outlook.com (2603:1096:201:20::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 28 Sep 2021 23:41:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a0b6112-210b-45d0-ffda-08d982d98040 X-MS-TrafficTypeDiagnostic: DF4PR8401MB1035: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4502; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +wrkoxTBAlYj0cEl5FeSh6s1oE/KQd18CSEllUvnzAF8TXO0ilNDATJpRFmRrel8RZigNdpnL+kKkQO7Ck1ynP+RSa/cMhhKuLfX3d4WcTPzcwt17IybKeOi5bXkzcUrQORvaUaDL2tB94Bed/Ge8gc3N6tLsqPDLo496z4CwF2MbNwf6ca/g+hAdgqrk+EBr9R3AS5f3uZdPOfeOXwkmRhUhbEuwvwJP6DYgn54f3vZLdwUShknRV8JWNM0+r8D9I2rKcK2ryfk16VX/3/dydD2eYQgEcONb/P+RWykIDn5Y+mbL+rtrS2DT7LvM7d61Dwk4VpqIrZdH9bxgE6aTlUu3SdEkn4sWF1If2a6YxAU9ilXn37FP8P/igT9LQH3QcsPMC1Vx60LN0lAnRw/fqnXw+kiuV830RuMuJc7RDlGPzSUsknXSO5UXTIefyF9HS9WfeJ5BpdmlbE8E3vdgOX8LPcFQogkgy8q6ydlCRhpKG2N6rSt1jaUACMk1JB1o6UsDL4erC5tB0BdSyT8XsjI4YYvqsNzBSZkW8w8WMZ8rWTshGiQdmCL7pP1QR1Gw45HoyaW47p7xqhXelFBolszwQMm9XXXzaryDr8WEXDCiAGkHmL1HiOp99Ow5Y81aRpOHzPBXB//d0+hdDaXd/JbSK9FXffJORWuXZ0eaAj0Gt/fN4l6tJnvokUUBEHfqduK72UhY8P3LljvkjC6pEEe2cdVZrjvbeCRQvQjLVbOARVwdnFSzoDBIqlOOyjtJe9qyDSgCN+NKRppeTTI3uTXZYZ7z2M/rJVzT3WEtawOWww9ky86ah5DIy6DGzNY5LExgEv4bDOl+ue3PZTubcSFF53Fjtr7ycw1iKzYIR0txuQFuahj76+OKzqy5w7UCXnoHyMxls3XVSJenfKiE9FbddCwdPR43CIYsNSy3tU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(366004)(956004)(36756003)(186003)(2906002)(66476007)(6666004)(30864003)(316002)(19627235002)(8936002)(44832011)(5660300002)(86362001)(31696002)(4326008)(53546011)(66556008)(26005)(66946007)(8676002)(54906003)(38100700002)(966005)(508600001)(31686004)(2616005)(83380400001)(16576012)(6486002)(156123004)(213903007)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SzNjM1Vzbis0ZCtYMHVrblVZcTlBUlNaSWhzODd6RWlKeEp4aWU4bXhNdENj?= =?utf-8?B?aEt1ZFVUTGZSa3VxSWpZd2N3M2FuQVoxT1U1T09XcE1aZldGdmR4Y0J4L0lE?= =?utf-8?B?SDF1ZFZrbjVxQmdIRnRIbEdNK2U1OFJldldJQXMyZlRWWEp6dXRNc3BUQ2t2?= =?utf-8?B?Q3N5YWh5L0NvaFZDRktzd0hjWmJPL2N0ZGVqbllyWWI2ckJBOGdwV01RSEM5?= =?utf-8?B?ZjFwWGkzcVY5cmRjWEZkNXBiVW9zVWVmYnhmcjVxQ0NuTXpBd08wN1F5Y0gw?= =?utf-8?B?U2t6bDJtTzNnd010d2dScHJVZzd6Y2c4TlBjNDJhTitQTWcySmNhQUFLUEZU?= =?utf-8?B?UHFNZDhVelNyNWp4bTNGT0lUbTkxbGZXdnRwdTJyWlh6RmFlN29LT1IyZ2Ez?= =?utf-8?B?bVZqSFU5eFY0c0t1V092T3ZjMFdjNVYwaGV4c3ppYTFXamRjbmwySEhWc1RR?= =?utf-8?B?OEJoekVscU5pWDZ3WWlUVmljSHR2dk0zOXQ5RHFtSkw4Q3ZNTSs3bkFQTmhu?= =?utf-8?B?Qy9HVEpRbkVmcWtQSjFsYmJsYzdVMWxjdk5jQVVYNlRKTlZ5ZzdOTStTM1Er?= =?utf-8?B?MkZVSXFEQzk0eWg5c0hQRWkvaTV5U3F5NFFGUTBYZFNVbnFOS0hudm95Nkp3?= =?utf-8?B?dkg2SHlaUkcvVEhGbGRUWEhKTUdaNm9OOWFZdmE5ZDhFdlRabDdONTI4ZnRk?= =?utf-8?B?cFBpY1lUaHNmY0EyUDdMVlBXSDZJQ0V5Z25zSldsS3RZNDFJdWlnVGI3M3d0?= =?utf-8?B?dlN4OGpDTytRWE5hbDNjcXZWaGhxUEY3bm5xQW9QRFlwYnc4UTh5TnprVU8y?= =?utf-8?B?MWFxayt5OUZKTnkxRTB1TTA3Mlk2WVJ3WnhGRlo1UEtGazEyYW53OGUvSXFm?= =?utf-8?B?Rm1GRHFVRHUvLzJXTE5HMlA5WHBGQzN3WmRLSndYc1NEQVpRa0gvb1BmVzNQ?= =?utf-8?B?ckNnMVczUVZMcDVkRFo0ZlY1c0MvYS9JNU00VlV5M1ZVb2lOK3JDSEJpYjBT?= =?utf-8?B?SG95dWVlK3FGT290QXFDVWY5K2NkY1RMdTdLMDBHeittL1ZvQzBwZEdGbWlN?= =?utf-8?B?TnlvRFdYNlRYSHpjcHh6UDRzZXJHc256UXpvTjBaWkQvVkUrRndET21yQXEz?= =?utf-8?B?WGg4V0g4cEhBYjBJWmFOU3ExOWFsZXZWRVl2eEJOY2F1ZFdyNnZsaFNLclpH?= =?utf-8?B?NXBGTE5GMHkvK25wTDhOdk5MQnlodG1ONXlBdUM3Z0Y5cS81UmhWUU5lOVB4?= =?utf-8?B?bjdMbjBWRXkxZVJ4QnFvK21sRzEzT3Foak9EekwrNTQyVGg2MXZqWU9Pc1dC?= =?utf-8?B?a2NGNHVMeEdhcTlwZTZWVTMzK1BCU1NaaDBRc0phVEVFT3pVamVWd0JxNUNM?= =?utf-8?B?WTJOWWJCSFoxYWI0VjFocWlXb2hqVC9OSzlvTkVmSG45S2xQTXozSUZ4UzBr?= =?utf-8?B?Y3k1YlJ1bDl6R1AxblByYzdXb0xjVGc3NWtIVy9QUzVPTFRvMUcyTDhVNzFx?= =?utf-8?B?Ylpvby8yS3UwRlN3K2FqTWQ5U3I4bHdKOVBWVnVsVkh3bHQvYTYwMHpmNlBT?= =?utf-8?B?d3dHRVFhUzQ1b3J3UGtZTkRvVDdjeE5yU3cxV1B1VnhqUk5HcmlWWDdJc28x?= =?utf-8?B?UEFPYXhmMXdrVzRGcmYxVW9WblNBV2JJbzYzV1dqK1ZvWjJtMnNBckNSZDFI?= =?utf-8?B?UE42cjhqVmE2bG4xUWZYMkl6TE5Bc1k2OFA0bGZTaXQzb1J3OFgzVFFWSnhV?= =?utf-8?Q?cyeCS5eFLncF5yQeXx7Tpsr1MuiZJO4qIVWSSa4?= X-MS-Exchange-CrossTenant-Network-Message-Id: 8a0b6112-210b-45d0-ffda-08d982d98040 X-MS-Exchange-CrossTenant-AuthSource: DF4PR8401MB0923.NAMPRD84.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2021 23:41:32.4171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5ShLBs2NKMLHUz8THcN6KdODV9pWQQDbFcVx2lIKuV8TPkiaiqAVoCi5XSG9lrENAkliQmI2ApNtxOUwhL0ueQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DF4PR8401MB1035 X-OriginatorOrg: hpe.com X-Proofpoint-ORIG-GUID: eGGKT-SM-Reme-1PhO8fupipC3jnXTkH X-Proofpoint-GUID: eGGKT-SM-Reme-1PhO8fupipC3jnXTkH X-Proofpoint-UnRewURL: 3 URL's were un-rewritten MIME-Version: 1.0 X-HPE-SCL: -1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-09-28_11,2021-09-28_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 priorityscore=1501 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=1015 mlxscore=0 phishscore=0 mlxlogscore=908 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2109280137 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Oh and this also needs to be followed up with a change to edk2-platforms. On 9/29/21 07:16, Daniel Schaefer wrote: > Please fix the issue in the maintainers file. > Looks good otherwise: > > Reviewed-By: Daniel Schaefer > > On 9/28/21 16:31, Abner Chang wrote: >> Relocate PciPcdProducerLib to OvmfPkg/Fdt, this library is >> leverage by both ARM and RISC-V archs. >> >> Add OvmfPkg/Fdt maintainers in Maintainers.txt >> >> Signed-off-by: Abner Chang >> Cc: Ard Biesheuvel >> Cc: Leif Lindholm >> Cc: Sami Mujawar >> Cc: Jiewen Yao >> Cc: Jordan Justen >> Cc: Gerd Hoffmann >> Cc: Daniel Schaefer >> Cc: Sunil V L >> --- >> ArmVirtPkg/ArmVirtCloudHv.dsc | 8 ++++---- >> ArmVirtPkg/ArmVirtKvmTool.dsc | 8 ++++---- >> ArmVirtPkg/ArmVirtQemu.dsc | 8 ++++---- >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 8 ++++---- >> .../Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf | 2 -- >> .../Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c | 0 >> Maintainers.txt | 6 ++++++ >> 7 files changed, 22 insertions(+), 18 deletions(-) >> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf (92%) >> rename {ArmVirtPkg/Library => OvmfPkg/Fdt}/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c (100%) >> >> diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/ArmVirtPkg/ArmVirtCloudHv.dsc >> index f159754bf4..2928b9adb5 100644 >> --- a/ArmVirtPkg/ArmVirtCloudHv.dsc >> +++ b/ArmVirtPkg/ArmVirtCloudHv.dsc >> @@ -49,7 +49,7 @@ >> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf >> QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf >> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> - PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> PciHostBridgeUtilityLib|ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf >> @@ -341,12 +341,12 @@ >> # >> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> @@ -360,5 +360,5 @@ >> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> ArmVirtPkg/CloudHvAcpiPlatformDxe/CloudHvAcpiPlatformDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> diff --git a/ArmVirtPkg/ArmVirtKvmTool.dsc b/ArmVirtPkg/ArmVirtKvmTool.dsc >> index ff70509542..3cc182545c 100644 >> --- a/ArmVirtPkg/ArmVirtKvmTool.dsc >> +++ b/ArmVirtPkg/ArmVirtKvmTool.dsc >> @@ -57,7 +57,7 @@ >> >> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> >> - PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> PciHostBridgeUtilityLib|ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf >> @@ -338,17 +338,17 @@ >> # >> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf >> } >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf >> } >> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> NULL|ArmVirtPkg/Library/BaseCachingPciExpressLib/BaseCachingPciExpressLib.inf >> } >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index f4bb14903f..85fcf5f310 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -77,7 +77,7 @@ >> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf >> QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf >> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> - PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> @@ -487,12 +487,12 @@ >> # >> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> @@ -543,5 +543,5 @@ >> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index eecef1a063..909968d13a 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -75,7 +75,7 @@ >> FrameBufferBltLib|MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.inf >> QemuBootOrderLib|OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.inf >> FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> - PciPcdProducerLib|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + PciPcdProducerLib|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf >> PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf >> PciHostBridgeUtilityLib|OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.inf >> @@ -423,12 +423,12 @@ >> # >> ArmPkg/Drivers/ArmPciCpuIo2Dxe/ArmPciCpuIo2Dxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridgeDxe.inf >> MdeModulePkg/Bus/Pci/PciBusDxe/PciBusDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> OvmfPkg/PciHotPlugInitDxe/PciHotPlugInit.inf >> OvmfPkg/VirtioPciDeviceDxe/VirtioPciDeviceDxe.inf >> @@ -459,5 +459,5 @@ >> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf { >> >> - NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> + NULL|OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> } >> diff --git a/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf b/OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> similarity index 92% >> rename from ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> rename to OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> index 1dfe779f6c..0f5156615b 100644 >> --- a/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> +++ b/OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf >> @@ -20,8 +20,6 @@ >> FdtPciPcdProducerLib.c >> >> [Packages] >> - ArmPkg/ArmPkg.dec >> - ArmVirtPkg/ArmVirtPkg.dec >> EmbeddedPkg/EmbeddedPkg.dec >> MdeModulePkg/MdeModulePkg.dec >> MdePkg/MdePkg.dec >> diff --git a/ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c b/OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c >> similarity index 100% >> rename from ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c >> rename to OvmfPkg/Fdt/FdtPciPcdProducerLib/FdtPciPcdProducerLib.c >> diff --git a/Maintainers.txt b/Maintainers.txt >> index 41f491bcae..c77b455381 100644 >> --- a/Maintainers.txt >> +++ b/Maintainers.txt >> @@ -463,6 +463,12 @@ R: Jiewen Yao [jyao1] >> R: Min Xu [mxu9] >> R: Tom Lendacky [tlendacky] >> >> +OvmfPkg: FDT related modules >> +F: OvmfPkg/Fdt/Cc: Leif Lindholm > > I think there's an issue with this line. Looks like two lines got mashed together by accident. > >> +R: Leif Lindholm >> +R: Gerd Hoffmann >> +R: Abner Chang >> + >> OvmfPkg: LsiScsi driver >> F: OvmfPkg/LsiScsiDxe/ >> R: Gary Lin >> > > > > >