From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.67, mailfrom: philmd@redhat.com) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by groups.io with SMTP; Thu, 11 Apr 2019 07:23:53 -0700 Received: by mail-wm1-f67.google.com with SMTP id c1so6973696wml.4 for ; Thu, 11 Apr 2019 07:23:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AvzA4O3d1ts2JyMWRN7jmbbkS3M4STC1Gdu58sfT2fo=; b=WtP3l3KSRPPSLk9xlRCM/gRjcdLKrqE8H50rnGOvKbgVDb/b4N5PE4645pFcnH3Xp/ wckcbPVYxmMDTkpDoFD0Ct+z77ibnW3t/jHp/lWlTEe8Mfki9IaeCeQtximpv6Mt5cko QSb2jBcZ58uErFs+IKPGDZMLq/E090+RzHAYgviWb6ZJEloFXoi2dwXdLY9i5+dD3/z1 IWW9z1Rb/yfie/Tqo+/fOHFHGtVAr4sHezDYUjty9WFM6WDGwd62LMveJ66Es3MkH4nF l/GkZSxhvbBF4Iiwj8K39yBPWKCIVjxa5UGbaw4OrlmL3PY9y+H2vYV5rKLRY/ipKGQN VXBA== X-Gm-Message-State: APjAAAXv0m34bKPD9h2Q1uhQL/XilASLkgHQvi/6HHb7z0PGhQQmI2p7 OVBFurRv9Aaxx+5PCx+5EKazCA== X-Google-Smtp-Source: APXvYqwupdKAOWB0RsqCrcBQlUN0osbY5ow0HcBSxaAFpp/3rCgLWvx21RZKExBF21DMLvTQzI+5CQ== X-Received: by 2002:a1c:4844:: with SMTP id v65mr6826522wma.139.1554992631956; Thu, 11 Apr 2019 07:23:51 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id g132sm5331410wme.3.2019.04.11.07.23.51 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 07:23:51 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64 To: devel@edk2.groups.io, rebecca@bluestop.org, Liming Gao , Yonghong Zhu References: <20190411031653.38092-1-rebecca@bluestop.org> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 11 Apr 2019 16:23:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190411031653.38092-1-rebecca@bluestop.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: > Some systems such as FreeBSD identify the platform as 'arm64' > and not 'aarch64' as Linux does. Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220297 this seems to be a FreeBSD bug. > Signed-off-by: Rebecca Cran > --- > BaseTools/Source/C/GNUmakefile | 5 +++-- > BaseTools/Source/C/Makefiles/header.makefile | 5 +++-- > 2 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/BaseTools/Source/C/GNUmakefile b/BaseTools/Source/C/GNUmakefile > index 1d048c4cc6..37bcce519c 100644 > --- a/BaseTools/Source/C/GNUmakefile > +++ b/BaseTools/Source/C/GNUmakefile > @@ -21,8 +21,9 @@ ifndef HOST_ARCH > endif > ifneq (,$(findstring aarch64,$(uname_m))) > HOST_ARCH=AARCH64 > - endif > - ifneq (,$(findstring arm,$(uname_m))) > + else ifneq (,$(findstring arm64,$(uname_m))) > + HOST_ARCH=AARCH64 > + else ifneq (,$(findstring arm,$(uname_m))) > HOST_ARCH=ARM > endif > ifndef HOST_ARCH > diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile > index 90fb3453ad..d76b8283dd 100644 > --- a/BaseTools/Source/C/Makefiles/header.makefile > +++ b/BaseTools/Source/C/Makefiles/header.makefile > @@ -23,8 +23,9 @@ ifndef HOST_ARCH > endif > ifneq (,$(findstring aarch64,$(uname_m))) > HOST_ARCH=AARCH64 > - endif > - ifneq (,$(findstring arm,$(uname_m))) > + else ifneq (,$(findstring arm64,$(uname_m))) > + HOST_ARCH=AARCH64 > + else ifneq (,$(findstring arm,$(uname_m))) > HOST_ARCH=ARM > endif > ifndef HOST_ARCH >