Re: [edk2-devel] [PATCH EDK2 v2 1/1] OvmfPkg/XenPvBlkDxe: add return value if allocting fail

["Laszlo Ersek" <lersek@redhat.com>]

On 11/24/20 10:19, wenyi,xie via groups.io wrote:
> It's OK to me.
> 
> Thanks
> Wenyi

Merged as commit f69a2b9a4202, via
<https://github.com/tianocore/edk2/pull/1151>.

Thanks
Laszlo

> On 2020/11/24 17:16, Laszlo Ersek wrote:
>> On 11/24/20 03:06, Wenyi Xie wrote:
>>> return EFI_OUT_OF_RESOURCES if pool allocating fail.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>> Cc: Anthony Perard <anthony.perard@citrix.com>
>>> Cc: Julien Grall <julien@xen.org>
>>> Signed-off-by: Wenyi Xie <xiewenyi2@huawei.com>
>>> ---
>>>  OvmfPkg/XenPvBlkDxe/BlockFront.c | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/OvmfPkg/XenPvBlkDxe/BlockFront.c b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> index 122a6baed25a..32d70c36cef2 100644
>>> --- a/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> +++ b/OvmfPkg/XenPvBlkDxe/BlockFront.c
>>> @@ -155,6 +155,10 @@ XenPvBlockFrontInitialization (
>>>    ASSERT (NodeName != NULL);
>>>  
>>>    Dev = AllocateZeroPool (sizeof (XEN_BLOCK_FRONT_DEVICE));
>>> +  if (Dev == NULL) {
>>> +    return EFI_OUT_OF_RESOURCES;
>>> +  }
>>> +
>>>    Dev->Signature = XEN_BLOCK_FRONT_SIGNATURE;
>>>    Dev->NodeName = NodeName;
>>>    Dev->XenBusIo = XenBusIo;
>>>
>>
>> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>>
>> Unless it's urgent for you, I'd like to merge this after
>> edk2-stable202011. It's a bugfix alright, but the issue seems to have
>> existed for a long time, with presumably no symptoms for most users.
>>
>> Thanks
>> Laszlo
>>
>> .
>>
> 
> 
> 
> 
>