From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=f6DHwPoz; spf=pass (domain: gmx.de, ip: 212.227.15.19, mailfrom: xypron.glpk@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by groups.io with SMTP; Wed, 11 Sep 2019 22:43:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1568266995; bh=HK8wB1qI7a3cPCl96QOZLmke7To+qkYkLwFw3SlTm1k=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=f6DHwPoz1ZZ5a9I3nb6inYiDJi3OeU9Be5tBeHps7zR+k1HQKM79f3Q6Diqc7RLja xnlhU+Bcjbsy4UB7jawyFc75aaKqEKzTzZn/EiAL9rddzVUJYlkF0Hx/eQgDkgNfId T8arQ8I90MK45LIbbJOpgroj69J24UEY96nAVyQc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.51] ([84.118.159.3]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0Lp3x6-1ie2CN2BAC-00ewIk; Thu, 12 Sep 2019 07:43:15 +0200 Subject: Re: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported To: "Jin, Eric" , EDK II Development Cc: Supreeth Venkatesh , Stephano Cetola References: <20190911184430.29684-1-xypron.glpk@gmx.de> From: "Heinrich Schuchardt" Message-ID: Date: Thu, 12 Sep 2019 07:43:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:kLdQVopuJkGGvLSjOsxotaYdL6VbmNDUov3xB4p3fQU5nkHSWMb ItAWhF35/hKxiyNSx4bHn6bq8G1rd+TPagR1EaX5MAIQCr+G8D3EaHsb4HYVgI2xCtJj4b7 Zyq6ZULPvTkce4Jy23c1/MuMJFaGAu3b8b56WechgemDqFafydmYKY2mNIfiw3ugKHDNlpP VdS9HzWI5NF06tbxvhHKg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:voyMEmvTnAM=:VH+q3C4ztmDtFMZUaxw7NV ePbJ3lsETegrxFx4Swu2MuDkg5rLQPq7TsxlldGA3570xAYHI35b7MxHa3nZSuKRGBwux5MQB MfznOxY1NWP99Ha40oqVCDtHfJ8zSBKM08D4nl8Zua92WWSW3Ef+lsYIr7Qp+W0cButvGwu95 an13jgJcuBPFaUZXur6bCUJNwEmXMXHVA33z7CkECfbOtcwirdkANlbJ9aFbbL6DCwFqKDA4m dlXq1A3rezT/F5aOShGGtCzB2rhSlsv6V65CFdHOaCU9q1Voi1Sgtm2paRdOLmAjAWXp0XiNK oDMkmtbKXXY5xDcKmna6U3Xiaq+yi/RF3sJhPX+pWRcGkxDOkkpAZXgV6JhV2CkkdCQIpI5AZ Kphd/uYnHAddWxGmsTkC20IbyA7iZ2yGcyceV2/UwNB47DRG/SM5M7ogjW123we375FeoSVam bCHPY3p6STSwtaj7dLOdZtDgZVECxW0YpW6vBpA9i1m1CaDcmLYmuPGIYj1JNdkFeKEics3z4 WjvMYSzkilmFsUN7BAgROU3FA3UVsy0YTsfyTGyeQoH8pLOQk91m/JskZ4AAfMYcRpsQQun2/ fIgsdztBDsWbiIOI5Vmkvpvwkd6dMAZVhEIp7+pDsCZLWIkMODFS9TcExikIMg3HKq+B9V0bu EWi/4/xROgzbgIYsy7qNP0EXRg16xpkOiUekjWSYZSghmt6PixVugwCN3u0X/jCJLtPuNDTrW 2z0zAV0RDk9GiGj8LWsmdd8KpMRFKCdDsL1n6Wa6pJznfJsTixrEGx+8j28kLi1m/pjn/zHv+ xb4C817LPO3+DDUHr0Y0ABvCjFVHAGYEkKMCgvAVxAQWHu4vGYBSKRkfD09hbSqZ5dfDDTWB3 5BUZJAoEDg45UZpa6zuRmCoCtss+XQgVmQEmi63pSCGRTuIfxmOJEIT01UP863Dp9hLBnpjju /7N8Ne8zgi9Ffnq8K84nB9567fpsOjjaA1/FcIgHWAk8fVprQHfp0aXNMeWIPuIuPJCNgjgg4 43GuCGkUaVp+Zyy9GOO/g8N7EeQjeAPR85ZsWE0ApAB2oA8STgUmAaccjIuwtWsXSlqqUQhC3 9QwR/jeGnTs7c+fa765pCEqYmJx54oZrPfS64xsaP96LmOUYeZWYZZgKSfqnAjo2yNbLh09ot AY2Cb2+5+mpDGaNOmJccU0WkxYvwG6EIeU9bW9ky+Jeel45iVCgEmuuJlg7rgngSIGwHA= Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 9/12/19 4:32 AM, Jin, Eric wrote: > Heinrich, > > Could you please provide your company/organization info in copyright par= t? Hello Eric, my work on EDK2 has neither been on behalf of a company or organization, nor have I received any remuneration for it. If you deem it appropriate, feel free to add my name. Best regards Heinrich Schuchardt > I could help to add it when I push the patch. > > With that - Reviewed by: Eric Jin > > Best Regards > Eric > > -----Original Message----- > From: Heinrich Schuchardt > Sent: Thursday, September 12, 2019 2:45 AM > To: EDK II Development > Cc: Jin, Eric ; Supreeth Venkatesh ; Stephano Cetola ; Heinrich S= chuchardt > Subject: [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle = state may be unsupported > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2169 > > The UEFI specification allows EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState= () > to return EFI_UNSUPPORTED if a state change is not supported. This for i= nstance may be the case when connecting via a serial connection. > > Up to now the SCT has marked the conformance test as FAILED if SetState(= ) was called with invalid parameters and EFI_UNSUPPORTED was returned whic= h contradicts the specification. > > Instead create a warning if SetState() returns EFI_UNSUPPORTED. This all= ows the user to check if the non-support is justified. > > Signed-off-by: Heinrich Schuchardt > --- > v2: > Issue warning if EFI_UNSUPPORTED is returned when called with > invalid parameters. > --- > .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputE= x/BlackBoxTest/SimpleTextInputExBBTestConformance.c b/uefi-sct/SctPkg/Test= Case/UEFI/EFI/Protocol/SimpleTextInputEx/BlackBoxTest/SimpleTextInputExBBT= estConformance.c > index d997b651..946cb274 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/Black= BoxTest/SimpleTextInputExBBTestConformance.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/SimpleTextInputEx/Black > +++ BoxTest/SimpleTextInputExBBTestConformance.c > @@ -483,8 +483,10 @@ BBTestSetStateConformanceTestCheckpoint1 ( > ); } }- - if ( EFI_INVALID_PARAMETER != =3D Status) {++ if (Status =3D=3D EFI_UNSUPPORTED) {+ AssertionType = =3D EFI_TEST_ASSERTION_WARNING;+ } else if (Status !=3D EFI_INVALID_PARAM= ETER) { AssertionType =3D EFI_TEST_ASSERTION_FAILED; } else { As= sertionType =3D EFI_TEST_ASSERTION_PASSED;-- > 2.20.1 > >