From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6DB3C7803E7 for ; Fri, 10 Nov 2023 09:11:38 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=JCdJTdCcZbSDbPROItxH40lRNRrk8IJWddswPZP3D+8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699607497; v=1; b=TVlNNeCgvvW9WI6taURA/tKMJgw7/Y+EJgpbade2TQY2kqVp5PX1RCuqpox4WHBenGwKnffY 6AKRcGhWh75jzSvWPKJAcFLB7Dp2cBvmuePMU7qXp6h3GHILbfZwodBXK03Q/0EMEic4VzeGRmO k46ZFsxwpzHhLK+2AlsneFo4= X-Received: by 127.0.0.2 with SMTP id lDdtYY7687511xdSYguzGLHn; Fri, 10 Nov 2023 01:11:37 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.23748.1699607496547732036 for ; Fri, 10 Nov 2023 01:11:36 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B8C6912FC; Fri, 10 Nov 2023 01:12:20 -0800 (PST) X-Received: from [192.168.1.25] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DF54A3F6C4; Fri, 10 Nov 2023 01:11:34 -0800 (PST) Message-ID: Date: Fri, 10 Nov 2023 10:11:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v2 01/11] ArmPkg/ArmScmiDxe: Rename PERFORMANCE_PROTOCOL_VERSION From: "PierreGondois" To: Leif Lindholm Cc: devel@edk2.groups.io, Sami Mujawar , Ard Biesheuvel , Michael D Kinney , Liming Gao References: <20231025112540.1654844-1-pierre.gondois@arm.com> <20231025112540.1654844-2-pierre.gondois@arm.com> In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,pierre.gondois@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 27flJ1OwGJEJVR4lrKrnXa0Ax7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=TVlNNeCg; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=arm.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hello Leif, On 11/2/23 11:20, Pierre Gondois wrote: > Hello Leif, > Thanks for the review, >=20 > On 10/26/23 12:05, Leif Lindholm wrote: >> On Wed, Oct 25, 2023 at 13:25:30 +0200, pierre.gondois@arm.com wrote: >>> From: Pierre Gondois >>> >>> Rename PERFORMANCE_PROTOCOL_VERSION to reflect the different >>> versions of the protocol. The macro is neither used in edk2 nor >>> in edk2-platforms. >> >> OK, so slight nitpick, but mainly because it parses a bit weirdly... >> *Will* it be used after this series is merged, or is this an update >> for completeness? >=20 > The 'fast channels' were added in the v2.0 SCMI specification. This patch= -set > relies on this feature, so it is checked in: > [PATCH v2 10/11] DynamicTablesPkg: Add ArmScmiInfoLib > that the underlying SCP is at least at this version. >=20 > ``` > // FastChannels were added in SCMI v2.0 spec. > if (Version < PERFORMANCE_PROTOCOL_VERSION_V2) { > DEBUG ((DEBUG_ERROR, "ArmScmiInfoLib requires SCMI version > 2.0\n= ")); > return EFI_UNSUPPORTED; > } > ``` >=20 >> >>> Signed-off-by: Pierre Gondois >>> --- >>> ArmPkg/Include/Library/ArmLib.h | 1 + >>> .../Include/Protocol/ArmScmiPerformanceProtocol.h | 13 ++++++++---= -- >>> 2 files changed, 9 insertions(+), 5 deletions(-) >>> >>> diff --git a/ArmPkg/Include/Library/ArmLib.h b/ArmPkg/Include/Library/A= rmLib.h >>> index 0169dbc1092c..7b2b2238fed9 100644 >>> --- a/ArmPkg/Include/Library/ArmLib.h >>> +++ b/ArmPkg/Include/Library/ArmLib.h >>> @@ -780,6 +780,7 @@ EFIAPI >>> ArmHasVhe ( >>> VOID >>> ); >>> + >>> #endif // MDE_CPU_AARCH64 >>> =20 >>> #ifdef MDE_CPU_ARM >>> diff --git a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h b/Arm= Pkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>> index 7e548e4765c2..8e8e05d5a5f6 100644 >>> --- a/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>> +++ b/ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h >>> @@ -1,12 +1,12 @@ >>> /** @file >>> =20 >>> - Copyright (c) 2017-2021, Arm Limited. All rights reserved. >>> + Copyright (c) 2017-2023, Arm Limited. All rights reserved. >>> =20 >>> SPDX-License-Identifier: BSD-2-Clause-Patent >>> =20 >>> - System Control and Management Interface V1.0 >>> - http://infocenter.arm.com/help/topic/com.arm.doc.den0056a/ >>> - DEN0056A_System_Control_and_Management_Interface.pdf >>> + System Control and Management Interface, latest version: >> >> I see this as a pattern throughout the series. >> But this statement will at some point become untrue; this >> implementation is written against a specific version. I think this >> version shold be reflected in the comment. (And that applies >> throughout the series.) >> >>> + - https://developer.arm.com/documentation/den0056/latest/ >> >> But I think the above is the most useful link. I was referring to this point I'm not sure I understood. Regards, Pierre >=20 > I am not sure I understand completely. Do you mean that the SCMI > structures/interfaces defined in: > ArmPkg/Include/Protocol/ArmScmiPerformanceProtocol.h > and that were written against the SCMI v1.0 specification should > not be used as such for other SCMI specification version ? > I.e. the same process as for the AcpiXX.h files > (MdePkg/Include/IndustryStandard/Acpi65.h) should be used ? >=20 > Or do you mean that the _CPC object generation implies that the > SCP should comply to the v2.0 version at least and this should be > reflected in the commit messages ? >=20 > Regards, > Pierre >=20 >> >> / >> Leif >> >>> + >>> **/ >>> =20 >>> #ifndef ARM_SCMI_PERFORMANCE_PROTOCOL_H_ >>> @@ -14,7 +14,10 @@ >>> =20 >>> #include >>> =20 >>> -#define PERFORMANCE_PROTOCOL_VERSION 0x10000 >>> +/// Arm Scmi performance protocol versions. >>> +#define PERFORMANCE_PROTOCOL_VERSION_V1 0x10000 >>> +#define PERFORMANCE_PROTOCOL_VERSION_V2 0x20000 >>> +#define PERFORMANCE_PROTOCOL_VERSION_V3 0x30000 >>> =20 >>> #define ARM_SCMI_PERFORMANCE_PROTOCOL_GUID { \ >>> 0x9b8ba84, 0x3dd3, 0x49a6, {0xa0, 0x5a, 0x31, 0x34, 0xa5, 0xf0, 0x= 7b, 0xad} \ >>> --=20 >>> 2.25.1 >>> -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111025): https://edk2.groups.io/g/devel/message/111025 Mute This Topic: https://groups.io/mt/102175810/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-