From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8C030740041 for ; Wed, 20 Sep 2023 11:49:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=2kkMTA+86ZadTC32ACql4AwchUvN0kJcRr3AdFJ00hc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695210562; v=1; b=GRBObwVthCUZWwKYxSDywvYyEwNn2nFNi8CxOVexsAL6tIY0bPTeqnlkvh9wIKbcjQbNlaVh CNObe582nyfIm1O1L6nqf/XP+npj42v9fmMiA+jD3EW0xWEZjA0hsOBzsai4QPaX7AWmvgBZWyO KbphLN442DOaLUYUeTz+O1BU= X-Received: by 127.0.0.2 with SMTP id ou8pYY7687511xq7CmOqfV7P; Wed, 20 Sep 2023 04:49:22 -0700 X-Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by mx.groups.io with SMTP id smtpd.web11.36494.1695210561374885534 for ; Wed, 20 Sep 2023 04:49:21 -0700 X-Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-502defbb0c3so11294682e87.0 for ; Wed, 20 Sep 2023 04:49:21 -0700 (PDT) X-Gm-Message-State: pD0eIt4dun3z3Hkdyf4aCEptx7686176AA= X-Google-Smtp-Source: AGHT+IFTNGCQyh1tVXAVnJQMUqHdgFu4jwA1V3f1wbzazqGcIAnlpliqxkmnfh5foKbWX/8c6XWs9Q== X-Received: by 2002:a19:7011:0:b0:501:c996:1996 with SMTP id h17-20020a197011000000b00501c9961996mr1666969lfc.67.1695210559405; Wed, 20 Sep 2023 04:49:19 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.3.58.ipv4.supernova.orange.pl. [83.11.3.58]) by smtp.gmail.com with ESMTPSA id w13-20020a05651203cd00b00502d555fb8asm2626051lfp.112.2023.09.20.04.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Sep 2023 04:49:19 -0700 (PDT) Message-ID: Date: Wed, 20 Sep 2023 13:49:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/QemuSbsa: define NS EL2 virtual timer in GTDT To: Leif Lindholm Cc: devel@edk2.groups.io, Graeme Gregory , Ard Biesheuvel References: <20230920082509.383643-1-marcin.juszkiewicz@linaro.org> <20230920082509.383643-2-marcin.juszkiewicz@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=GRBObwVt; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 20.09.2023 o 12:04, Leif Lindholm pisze: > On Wed, Sep 20, 2023 at 10:25:09 +0200, Marcin Juszkiewicz wrote: >> Armv8.1+ cpus have Virtual Host Extension (VHE) which added non-secure >> EL2 virtual timer. > It's still valid to use other CPUs than "max" with this platform. > Don't we need to conditionalise this based on the contents of the VH > bits in ID_AA64MFR1_EL1? Most of cpu cores available for SBSA Reference Platform are v8.2+ ones. And default is Neoverse-N1. > Ideally, we'd add a helper function in edk2 > ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c, like ArmHasCcidx(), and > conditionalise on that. > > Hmm, but we'd probably also need to move from .aslc to manually > construction GTDT in SbsaQemuAcpiDxe... > > If you're up for doing the GTDT rework, I could create the ArmLib > helper function. Sooner or later it needs to be done anyway as we need to add system timers there (which iirc only Ampere does in EDK2). -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108908): https://edk2.groups.io/g/devel/message/108908 Mute This Topic: https://groups.io/mt/101474460/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-