From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 83E4E78003C for ; Thu, 18 Jan 2024 23:35:24 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=WoPYfaGb2ewYRb3/c7l7ZGb+7VHruiHDKXHwHN+LUDc=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1705620923; v=1; b=ZfYowO9HIqAKbsXxMT5vsS2pXXRoIX24RjN7UFG6ZNzcAX6sS4BCsdyQBHDyFL/kvDO3u1cW VCokJDKY7fZgM2sp1+E15rgmSoFU43zS+kWtJ2A2ZHn9ktMpxDDgx/BrXRwjbg8CmQ9Pnc5gIaq +wNHu/sYpn/pK9Bc94nUFRB8= X-Received: by 127.0.0.2 with SMTP id tPJqYY7687511xF7yU58yukP; Thu, 18 Jan 2024 15:35:23 -0800 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.115]) by mx.groups.io with SMTP id smtpd.web10.9006.1705620922403138876 for ; Thu, 18 Jan 2024 15:35:22 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gGfplrXqODYRfOLWsaZWKygQF/3mVpLrgNHRh6rpxv/Pw+0e4aUU+7JwiKx2w4lFpUi+JCpI55H3I9/wMV9sAK75o1xerYRJCNuqUVUVi4ejyKrz+yhNlXQ4UQ8QOAHRnRiX6ddoaCz9Wq3L0Mg09rafPg904E/s1RzNyC0KccfiyWF/khfDWoYvNG0Va/XWkBXcZGHFGIkv/wUPqn6wi/2E4cOhCid/bZbnNBgdahXzhXF2Vh/E3ivFRHKU6zJgSX+T78ATltOjq2pzdh3lHfsNrpkaca85Es791gMi7wc17QOCvrbAQQELFqsmg7oiaO1pG2AYMd+L0HAFUMreww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mKprjx2sKdlcwr03O7iCuqrssJtH/JOy89YrHsX9mc4=; b=M100SheWOlBHmJywo9HogKLpX2+6GxglClsvgSIn5mfBpEb8OlmyZWXyv590HapFc+u5angcfYzHz1o99r8VZc74z0VNFHvtE5C521wl5vb6y9fVubEgU1zkV0gGhrewKBaoxele9Xyls0AHbRF+9ZpmRDzib13xS0BloE/o6xJNKHxH+AkU0Hff+f3ifUnHwWOcQreezoYmFc7Xx91R/jkYgO9m2ULy7gBp3qINvJ+5AJqN2IU2VgGhLgg2Ntrqq36Lf6pTaHTV9ZwX9tcG9k6ePJ/4pc3yZeLD4q7V1MDVyJcCi6zGtHe3CBHUTEY05yEqjbmaOvzbzJJlb+aZlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by BY3PR01MB6754.prod.exchangelabs.com (2603:10b6:a03:365::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.24; Thu, 18 Jan 2024 23:35:15 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7202.024; Thu, 18 Jan 2024 23:35:15 +0000 Message-ID: Date: Thu, 18 Jan 2024 16:35:11 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v3 3/3] ArmPkg: Disable watchdog interaction after exiting boot services To: Sami Mujawar , Leif Lindholm , Ard Biesheuvel Cc: "devel@edk2.groups.io" , nd References: <20240105051430.465510-1-rebecca@os.amperecomputing.com> <20240105051430.465510-4-rebecca@os.amperecomputing.com> From: "Rebecca Cran via groups.io" In-Reply-To: X-ClientProxiedBy: CH0PR04CA0039.namprd04.prod.outlook.com (2603:10b6:610:77::14) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|BY3PR01MB6754:EE_ X-MS-Office365-Filtering-Correlation-Id: d9394bb7-6dc7-4c8d-fb4f-08dc187e1f9b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: zaA1W5rkjYOJPT3G/wc3Vjnt3aK+hes79zur6ntT5OBoZ2nNWbEkN2fq0FZ0c9DuItxpAuD5Fn2PzpxS+SOXSEWsjT9+TwMaHN6vtcchFI7aASOmTbAHgdvWd8LZYtveSyqO45aH2IHSL4CgoVXIyM47mfXLkuq6qeEQ9+yFYP2BKkPJYPDU0otsCbhtA3ShT4eaZwq1HTBk2oBqxkUv7qRIELZELmGjVkKuQgXxoHSzL5Qp41XT3eoZ+jqeCLN7YaUUGQ7XITXtQpJim4FhW0qq98YRKLHcx8NxR12enlA5iQ2V5mNWQXzbJQYUFQhoMJq6YJ6t6nPsPhxsqWIG+PhMfPGcQHI7RaDGip3EGIiCeuFQvX+NSYeq7ggNKGzbxpe9U8nq/sbDiPocP1d0WqKnSa8Rc6pazHfYyxfNz8GNO0Xmgahg1Bo29gHAdZd7YsJ1P8iJ7+WTOMWubkCMspkUUGTjDmQXSvyr2qCXgSuV+Rkx3PDrdIzjj2dfzhMC1rZNuspJod0ggiVA5hvL5wIF89v5o7oDsc8CfdznSshQZtzv0Bxtg8YIc4U9rRdPOJPPY2l5fk4qrXDupmeEQdlVYf5FdJkmKVxV9t72v98kc9nXV3BUf3fuhc2FjD0F X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ekJIa21EMklYNTlQOHBpWjQ1dlVJVVBvTDE1SmUvV2loZ1F1anN4Y0VMdHlz?= =?utf-8?B?akZsRW90bWVQVHVLZXY2TEhHWHpDZmtNdHhlbjVyV3l6N29kNmxWVlRXTUhH?= =?utf-8?B?TGkzUEgyaDR6aDduUE95UG1aSWRSZnZLb20rSTZTRmlFM3FxQnZpZHRWWk1k?= =?utf-8?B?OFBmb2FhMXd6dXhjbUx3YVc1NTNKa3M3TmZpUWxnbE1YNk9OMFRIRXRjYlBK?= =?utf-8?B?emJkVzIzSFc0dGVkMS9sdDUvMFNDOVpMS3NjaDlwY1NweGhwTWpsQ2c1ekJr?= =?utf-8?B?M0EyQ3NOWEEwUW53TTdodkVhYzg3Q2xvKzdaRDFRYVRwUkl1aGFDcDdDb2M5?= =?utf-8?B?a0Q4T1gxalk0TlhtS0VxSDlCa3Q0RloycXdlYW5RSWREdENIMVFYOUtmYjE3?= =?utf-8?B?S0IrUVhzb2dLT1JLSGoyUTAwbFVYU3dkTHlPOWZWYi80Y0NpQ3VtR2djZHR4?= =?utf-8?B?Um9CR2E2Rlc2NW9SL2JiSFAxVXZzTUV5Tm1jWC8vNStFSC9RYlF3aDN5S0hp?= =?utf-8?B?Ny95NmdvcHNheDZXdUduWFBwY3owbkJpUmZKQ2l1V3NzekUxUFVpeVdyeEV3?= =?utf-8?B?dVFZeHJHb2dYWU9oQnVzc3dQZW52QVlrSzNXMXhWTkxZMjRtQnZ1YllJZUlj?= =?utf-8?B?T0gvY3hHU1pRV1RicnZVWXc5MXNEZEJNMThmVWwvcHpSSUZEYmVpL09WWmlx?= =?utf-8?B?blo2Y3pBOGl3c3U3Rk1Jd2FEMERLU0ZwT25EcXB5RnNmdEVIeDlwdkgzMDk5?= =?utf-8?B?dXliZXdacFlSSzZzc3FzTTNPNnczZVpLVkxBVlhNNUQza1lDeHBKajFuNE15?= =?utf-8?B?RzF1S0xtNmhadlRmSUZBQTlKV21Rd2tadWhVWlpxcWxQQk9tcEpEUC9pMm5L?= =?utf-8?B?cFJoVHZ2dGtXekhHSmJodTJSNzFhMUdjekFJeEI5TjRvaldjUEtwWUdESHBR?= =?utf-8?B?VHJZUmhjVnpKdmFLT1h2YVBBbkY4QlIzV29nblZvcFA4MGFoUUI0ZGkzYklF?= =?utf-8?B?Y3VONkdQM0VoYXc5L3RtaTJiV2NlNlYzY1cwM1pJclRsY3BGS28xM2paVXE5?= =?utf-8?B?L3lyRE1hZ0JiQ215RTlCSGJFRkhaVjVrakVhMHJLMXMrcWVTL2Raeko4bWkz?= =?utf-8?B?UTllVjU3TGZTZ05pdCtReW5aakRpRUNyMHFHOEtiVysxRUxJOFp3Z2ludENx?= =?utf-8?B?T0dmQmw3eTdNZ0ZoMVllNmhYbCtHZGRzVmNoKzV3eDVQK0ttcDFxY3llODRH?= =?utf-8?B?NG13d3V0bGY4Y0krUWhmMXB2UTJ0b0ZKbzhZLzZvMDN6WitpQysyLy90am1n?= =?utf-8?B?blpLTGtFaDROZVUwTDdWVFgybXJpazJLOGZxblFnaGtjREVDc2dyM1FacUJt?= =?utf-8?B?dVhlWldEejZyRFF5cWhtTmFtbFI0djdSUU13OER1RGduak9hM3Z1eEQyWlZ0?= =?utf-8?B?SDR0MmNFYVU3czQwQWxyZm9EM1FpRnd1cHhrakV4S09GUUNjbC9MSGpBYng1?= =?utf-8?B?VnVHWXF0VFdSL3ZaUkxyNEhZWkU1aCs1NlZKaGsxMmdoMVNDbGpyUnJ1TnEz?= =?utf-8?B?NnV1cEdwT0MxUlhlRFcyWmgxbk1RSkFoM2ZwaTBYQkZWNVpqRGpvQUM4QnVq?= =?utf-8?B?K0Y4Snk2UUdwc0xYcFU3Z2Ezd0l4TFRiK1NGd0FNSjFYZkV0MDNzeVZMVXR5?= =?utf-8?B?d3FBR1RXMVRyQzgrRVRyMUF5bFNTMWlXeHdma0pMblQxa2U5OFRKOVJPNlRE?= =?utf-8?B?YjFtejloYzVraG1mWlpBSWozUmdxT3RlV3Jid2JSVm1RS2c0TGxkWk9PYXRX?= =?utf-8?B?K1M2dmpwMmh0amRxcXllcExkQWh2T0xSWUFZUFkyNWR2YUlTSDdNMlQxWXNv?= =?utf-8?B?dWcvNjJDcm85ZHIzUXF4YkhsQTc1cG1XU1pPTmtkZW1aS3dhRUlnc0FCSTdN?= =?utf-8?B?enYwQktucEV5QkRpS25DOW1YZWY1UzA4Nk5EU0tWaENuYmdZeE5Ld1hxUTVs?= =?utf-8?B?bzhFT3FITE51QWpFRXptSmRUTVkxRVo5S3RrbDJHaytFMlhqQk44ODFvNW9z?= =?utf-8?B?cGsrOFo1amRqOUZWREdPVTY1MnB3NitNL29TeE9Ld0wxUXQwOWR1VlpUdGor?= =?utf-8?B?QlZqbkdyc0NXUnBLcDlZWWZySlREd2phNFRVamhlYVUvWHN6clJ0endFZUpV?= =?utf-8?Q?0WAD3H4VV+MVz92kG7fjQkM=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9394bb7-6dc7-4c8d-fb4f-08dc187e1f9b X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2024 23:35:15.6559 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /1IMrfzxn1MA12OLPEiqo9qtCpqwoe11aNiSXSRjFlFAuUTeA1Nc0xIUMSilWfBacMyAqg7qVum2sYaEnWhJTAJVDbH31JjGGW3zWMopeq/2l7+lp8ghBQhRDeu4Tehd X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR01MB6754 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: aHk6Md657awt6xB75x5fE1Wix7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZfYowO9H; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/5/2024 4:12 AM, Sami Mujawar wrote: > - // if TimerPeriod is 0, this is a request to stop the watchdog. > + // If we've exited Boot Services but TimerPeriod isn't zero, this > + // indicates that the caller is doing something wrong. > + if (mExitedBootServices && (TimerPeriod !=3D 0)) { > [SAMI] Thanks for updating the code to return the error code. > However, I see you are not stopping the watchdog timer. Is this because y= ou expect the watchdog period to expire and reset the system? I removed the code to stop the watchdog timer because it's an error=20 condition. However, I've updated it so it does also get stopped in this=20 case too. > Also, did you see an issue that motivated this patch, or this was just a = case of hardening the code? > Can you provide more information, please? > [/SAMI] This was issues found and improvements made by various people in the=20 last couple of years that we're now upstreaming to contribute=20 improvements and reduce our diffs against upstream. --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114018): https://edk2.groups.io/g/devel/message/114018 Mute This Topic: https://groups.io/mt/103538118/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-