From: "Laszlo Ersek" <lersek@redhat.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Sean Brogan <sean.brogan@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
Date: Tue, 3 Dec 2019 21:39:44 +0100 [thread overview]
Message-ID: <d315616c-9d61-e985-b669-27231bc51809@redhat.com> (raw)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F5B9E26278@ORSMSX113.amr.corp.intel.com>
On 12/03/19 18:07, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I can think of ways we may be able to get the label
> information into the body of the email in a PR comment.
> I will have to see if there is anyway to adjust the subject
> of the email. The subject appears to always match the title
> of the PR. That title is editable, but may only be editable
> using GitHub APIs. Mergify does not support that feature
> today.
>
> If you look at the following file, you will see the current
> Mergify rules.
>
> https://github.com/tianocore/edk2/blob/master/.mergify/config.yml
>
> If I look at the 3rd rule for merge conflicts, I could split
> that out into 2 rules. One for push label set and one for
> push label not set and adjust the message generated to state
> if the conflict is on a personal build or a push request.
>
> Would small adjustments like this in the body of the email
> notifications help? If we make the generated messages consistent
> email filters on the content of the email body can be used
> instead of email filters on the email subject.
Sounds great, thank you. I've checked the mail filtering solution that's
available to me, and it appears capable of scanning email bodies.
I suggest picking a GUID for the message body, in best UEFI style :) ,
for representing the *absence* of the "push" label. I generally prefer
watching all kinds of notifications about the edk2 repo, *except* the
personal CI builds.
> Each developer can enable/disable the 'Watch' feature on the
> edk2 repo. That is a developer setting, not a team setting.
Thanks!
Laszlo
next prev parent reply other threads:[~2019-12-03 20:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 2:55 EDK II Maintainers - EDK II CI is now active on edk2/master Michael D Kinney
2019-11-12 8:56 ` [edk2-devel] " Laszlo Ersek
2019-11-12 19:50 ` Michael D Kinney
2019-11-12 19:52 ` Michael D Kinney
2019-11-13 7:56 ` Laszlo Ersek
2019-11-13 8:57 ` Laszlo Ersek
2019-11-13 16:23 ` Michael D Kinney
2019-11-13 17:03 ` Laszlo Ersek
2019-11-26 8:23 ` Laszlo Ersek
2019-11-27 19:03 ` Michael D Kinney
2019-11-28 12:00 ` Laszlo Ersek
2019-12-02 19:55 ` Michael D Kinney
2019-12-03 8:56 ` Laszlo Ersek
2019-12-03 17:07 ` Michael D Kinney
2019-12-03 20:39 ` Laszlo Ersek [this message]
2019-12-06 11:02 ` Laszlo Ersek
2019-12-06 11:07 ` Laszlo Ersek
2020-01-02 14:42 ` Philippe Mathieu-Daudé
2020-01-02 18:36 ` Michael D Kinney
2020-01-06 14:58 ` Philippe Mathieu-Daudé
2020-01-03 13:29 ` Laszlo Ersek
2020-01-06 17:29 ` Laszlo Ersek
2020-01-06 18:17 ` Michael D Kinney
2020-01-07 9:00 ` Laszlo Ersek
2020-01-09 21:30 ` Laszlo Ersek
2020-01-09 21:37 ` Michael D Kinney
2020-01-10 10:51 ` Laszlo Ersek
2020-03-08 11:12 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2020-03-08 19:21 Sean
2020-03-08 19:53 ` Michael D Kinney
2020-03-09 19:29 ` Laszlo Ersek
2020-03-09 19:32 ` Laszlo Ersek
2020-03-09 22:00 ` Michael D Kinney
2020-03-09 19:37 ` Laszlo Ersek
2020-03-09 20:06 ` Laszlo Ersek
2020-03-09 21:44 ` Michael D Kinney
2020-03-10 7:53 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d315616c-9d61-e985-b669-27231bc51809@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox