From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.1761.1575405592811269365 for ; Tue, 03 Dec 2019 12:39:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=apwXgKWw; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575405591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ajT/UlJVXcAHK66jTLrBLjL/qnTDQh6c3b20iX7cD9U=; b=apwXgKWw0KAh6eq3Fcrla4/RQ4PxGdPBfhYG7VIlJip7j69vY906/zk/wg4aHzBOwB5ijZ Hn3dHtD0KHFyseaeu7txaj6thfWeoYezGSnSkNzJ0f+uhDoGFnZgyVQlGWeqBWzbX/8Fvr Ac7feICBUnzdAxa9NjOOctq4GH9icgk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-kTjT9-XGNAurBSl8xYQPQA-1; Tue, 03 Dec 2019 15:39:48 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1D1891005509; Tue, 3 Dec 2019 20:39:47 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-183.ams2.redhat.com [10.36.117.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADF7D67E59; Tue, 3 Dec 2019 20:39:45 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master To: "Kinney, Michael D" , "devel@edk2.groups.io" , Sean Brogan , Bret Barkelew , "Gao, Liming" References: <545f1da9-a998-1095-57f9-085cbd535596@redhat.com> <184dbbde-0916-7e09-476c-de700cc57dc5@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 3 Dec 2019 21:39:44 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: kTjT9-XGNAurBSl8xYQPQA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/03/19 18:07, Kinney, Michael D wrote: > Hi Laszlo, > > I can think of ways we may be able to get the label > information into the body of the email in a PR comment. > I will have to see if there is anyway to adjust the subject > of the email. The subject appears to always match the title > of the PR. That title is editable, but may only be editable > using GitHub APIs. Mergify does not support that feature > today. > > If you look at the following file, you will see the current > Mergify rules. > > https://github.com/tianocore/edk2/blob/master/.mergify/config.yml > > If I look at the 3rd rule for merge conflicts, I could split > that out into 2 rules. One for push label set and one for > push label not set and adjust the message generated to state > if the conflict is on a personal build or a push request. > > Would small adjustments like this in the body of the email > notifications help? If we make the generated messages consistent > email filters on the content of the email body can be used > instead of email filters on the email subject. Sounds great, thank you. I've checked the mail filtering solution that's available to me, and it appears capable of scanning email bodies. I suggest picking a GUID for the message body, in best UEFI style :) , for representing the *absence* of the "push" label. I generally prefer watching all kinds of notifications about the edk2 repo, *except* the personal CI builds. > Each developer can enable/disable the 'Watch' feature on the > edk2 repo. That is a developer setting, not a team setting. Thanks! Laszlo