From: "Maciej Rabeda" <maciej.rabeda@linux.intel.com>
To: mikuback@linux.microsoft.com, devel@edk2.groups.io
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>
Subject: Re: [PATCH v2 7/8] NetworkPkg/TcpDxe: Fix debug macro arguments
Date: Fri, 2 Sep 2022 16:30:11 +0200 [thread overview]
Message-ID: <d3234502-cef4-e451-ecf9-979aa12397ed@linux.intel.com> (raw)
In-Reply-To: <20220825034824.4044-8-mikuback@linux.microsoft.com>
Thanks for the patch, Michael.
Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com>
On 25 sie 2022 05:48, mikuback@linux.microsoft.com wrote:
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Removes Status argument that is not needed from DEBUG macros.
>
> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com>
> Cc: Jiaxin Wu <jiaxin.wu@intel.com>
> Cc: Siyuan Fu <siyuan.fu@intel.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
> ---
> NetworkPkg/TcpDxe/SockInterface.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInterface.c
> index 413d6e1373f3..6e8cbb74a86b 100644
> --- a/NetworkPkg/TcpDxe/SockInterface.c
> +++ b/NetworkPkg/TcpDxe/SockInterface.c
> @@ -661,11 +661,7 @@ SockSend (
> );
>
> if (NULL == SockToken) {
> - DEBUG (
> - (DEBUG_ERROR,
> - "SockSend: Failed to buffer IO token into socket processing SndToken List\n",
> - Status)
> - );
> + DEBUG ((DEBUG_ERROR, "SockSend: Failed to buffer IO token into socket processing SndToken List\n"));
>
> Status = EFI_OUT_OF_RESOURCES;
> goto Exit;
> @@ -674,11 +670,7 @@ SockSend (
> Status = SockProcessTcpSndData (Sock, TxData);
>
> if (EFI_ERROR (Status)) {
> - DEBUG (
> - (DEBUG_ERROR,
> - "SockSend: Failed to process Snd Data\n",
> - Status)
> - );
> + DEBUG ((DEBUG_ERROR, "SockSend: Failed to process Snd Data\n"));
>
> RemoveEntryList (&(SockToken->TokenList));
> FreePool (SockToken);
next prev parent reply other threads:[~2022-09-02 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-25 3:48 [PATCH v2 0/8] Fix imbalanced debug macros Michael Kubacki
2022-08-25 3:48 ` [PATCH v2 1/8] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier Michael Kubacki
2022-08-25 10:15 ` [edk2-devel] " Leif Lindholm
2022-09-02 22:29 ` Michael Kubacki
2022-08-25 3:48 ` [PATCH v2 2/8] FatPkg/FatPei: Remove extraneous debug message argument Michael Kubacki
2022-08-25 3:48 ` [PATCH v2 3/8] MdeModulePkg: Fix imbalanced debug macros Michael Kubacki
2022-08-25 3:48 ` [PATCH v2 4/8] RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument Michael Kubacki
2022-08-25 3:48 ` [PATCH v2 5/8] SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print specifier Michael Kubacki
2022-08-25 6:02 ` Yao, Jiewen
2022-08-25 3:48 ` [PATCH v2 6/8] DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments Michael Kubacki
2022-09-01 10:42 ` Sami Mujawar
2022-08-25 3:48 ` [PATCH v2 7/8] NetworkPkg/TcpDxe: " Michael Kubacki
2022-09-02 14:30 ` Maciej Rabeda [this message]
2022-08-25 3:48 ` [PATCH v2 8/8] OvmfPkg/LegacyBootManagerLib: " Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3234502-cef4-e451-ecf9-979aa12397ed@linux.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox