From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.7207.1662129021762247243 for ; Fri, 02 Sep 2022 07:30:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=VvrVV1nJ; spf=none, err=permanent DNS error (domain: linux.intel.com, ip: 134.134.136.31, mailfrom: maciej.rabeda@linux.intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662129021; x=1693665021; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=HdbvLGiujNszd79kZFi+mIM6gk0ciwv/qJWP+/vTwMs=; b=VvrVV1nJnJAZ6i56QOKdPGHVsuSh5LYnhou4fxzCx6KBf7jNrjUWEZ7/ Q1PnYx2wvsbM4rIDjJdMEHa58N4K1O6kMhzE7Ro6BMJV0hxG8OPrPxg6i EcfBrs/WAnklbMxelKOctvuz5c/QJ96zzoXFThcyPvp07oqERkd3BdsP8 pMcCP05CgH4r3Y6B9qmDP3pSHATOfJ8rRUYrzXRSYKHV0sqwEEmcch+sE qSqeuVbAHCaZ8j5uHggD9DUIW2pClQ/I3L/00izhzW4qgVORsH251Tkgj J5FOfZsdqHARGSRDTE5/XqZmZgZUCz/F2ToNR3MV+ZZbwBRwQ6wCydlHW Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10457"; a="357708458" X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="357708458" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 07:30:21 -0700 X-IronPort-AV: E=Sophos;i="5.93,283,1654585200"; d="scan'208";a="563978363" Received: from mrabeda-mobl2.ger.corp.intel.com (HELO [10.237.142.96]) ([10.237.142.96]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2022 07:30:20 -0700 Message-ID: Date: Fri, 2 Sep 2022 16:30:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 7/8] NetworkPkg/TcpDxe: Fix debug macro arguments To: mikuback@linux.microsoft.com, devel@edk2.groups.io Cc: Jiaxin Wu , Siyuan Fu References: <20220825034824.4044-1-mikuback@linux.microsoft.com> <20220825034824.4044-8-mikuback@linux.microsoft.com> From: "Maciej Rabeda" In-Reply-To: <20220825034824.4044-8-mikuback@linux.microsoft.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the patch, Michael. Reviewed-by: Maciej Rabeda On 25 sie 2022 05:48, mikuback@linux.microsoft.com wrote: > From: Michael Kubacki > > Removes Status argument that is not needed from DEBUG macros. > > Cc: Maciej Rabeda > Cc: Jiaxin Wu > Cc: Siyuan Fu > Signed-off-by: Michael Kubacki > --- > NetworkPkg/TcpDxe/SockInterface.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/NetworkPkg/TcpDxe/SockInterface.c b/NetworkPkg/TcpDxe/SockInterface.c > index 413d6e1373f3..6e8cbb74a86b 100644 > --- a/NetworkPkg/TcpDxe/SockInterface.c > +++ b/NetworkPkg/TcpDxe/SockInterface.c > @@ -661,11 +661,7 @@ SockSend ( > ); > > if (NULL == SockToken) { > - DEBUG ( > - (DEBUG_ERROR, > - "SockSend: Failed to buffer IO token into socket processing SndToken List\n", > - Status) > - ); > + DEBUG ((DEBUG_ERROR, "SockSend: Failed to buffer IO token into socket processing SndToken List\n")); > > Status = EFI_OUT_OF_RESOURCES; > goto Exit; > @@ -674,11 +670,7 @@ SockSend ( > Status = SockProcessTcpSndData (Sock, TxData); > > if (EFI_ERROR (Status)) { > - DEBUG ( > - (DEBUG_ERROR, > - "SockSend: Failed to process Snd Data\n", > - Status) > - ); > + DEBUG ((DEBUG_ERROR, "SockSend: Failed to process Snd Data\n")); > > RemoveEntryList (&(SockToken->TokenList)); > FreePool (SockToken);