From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.10030.1623767392574170399 for ; Tue, 15 Jun 2021 07:29:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 074DA12FC; Tue, 15 Jun 2021 07:29:51 -0700 (PDT) Received: from [10.57.7.205] (unknown [10.57.7.205]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 3590A3F719; Tue, 15 Jun 2021 07:29:48 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2 0/4] Update Node to 14.x to resolve cspell failure To: devel@edk2.groups.io, kuqin12@gmail.com Cc: Sean Brogan , Bret Barkelew , Michael D Kinney , Liming Gao , Laszlo Ersek , Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Jiewen Yao , Supreeth Venkatesh References: <20210614183431.1657-1-kuqin12@gmail.com> From: "PierreGondois" Message-ID: Date: Tue, 15 Jun 2021 15:29:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210614183431.1657-1-kuqin12@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Kun and Sean, As a follow-up to your patch-set, it seems that the spell checker does no= t currently run as expected. It only runs on files that are 'one level de= ep' in each package. I.e.: This was taken from Build/CI_BUILDLOG.txt from the TARGET_ARM_ARMPLATFORM= artifact at https://dev.azure.com/tianocore/edk2-ci/_build/results?build= Id=3D23939&view=3Dartifacts&pathAsName=3Dfalse&type=3DpublishedArtifacts = but this can be checked when running the CI locally on ArmPlatformPkg: -------Log start--------- INFO - Cmd to run is: cspell --config /home/vsts/work/1/s/Build/ArmPlatfo= rmPkg/cspell_actual_config.json ArmPlatformPkg/**/*.c ArmPlatformPkg/**/*= .h ArmPlatformPkg/**/*.nasm ArmPlatformPkg/**/*.masm ArmPlatformPkg/**/*.= asl ArmPlatformPkg/**/*.dsc ArmPlatformPkg/**/*.dec ArmPlatformPkg/**/*.f= df ArmPlatformPkg/**/*.inf ArmPlatformPkg/**/*.md ArmPlatformPkg/**/*.txt INFO - ------------------------------------------------ INFO - --------------Cmd Output Starting--------------- INFO - ------------------------------------------------ INFO -=C2=A0 1/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.c 829.4= 8ms INFO -=C2=A0 2/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.c 37.06ms INFO -=C2=A0 3/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.c 13.01ms INFO -=C2=A0 4/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.c 16.99ms INFO -=C2=A0 5/22 ./ArmPlatformPkg/PrePeiCore/MainMPCore.c 25.68ms INFO -=C2=A0 6/22 ./ArmPlatformPkg/PrePeiCore/MainUniCore.c 19.50ms INFO -=C2=A0 7/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.c 20.86ms INFO -=C2=A0 8/22 ./ArmPlatformPkg/PrePi/MainMPCore.c 18.98ms INFO -=C2=A0 9/22 ./ArmPlatformPkg/PrePi/MainUniCore.c 9.86ms INFO - 10/22 ./ArmPlatformPkg/PrePi/PrePi.c 26.83ms INFO - 11/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCore.h 15.71ms INFO - 12/22 ./ArmPlatformPkg/PrePi/PrePi.h 16.49ms INFO - 13/22 ./ArmPlatformPkg/ArmPlatformPkg.dsc 21.03ms INFO - 14/22 ./ArmPlatformPkg/ArmPlatformPkg.dec 24.63ms INFO - 15/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeiLib.inf 11.12ms INFO - 16/22 ./ArmPlatformPkg/MemoryInitPei/MemoryInitPeim.inf 15.85ms INFO - 17/22 ./ArmPlatformPkg/PlatformPei/PlatformPeiLib.inf 9.89ms INFO - 18/22 ./ArmPlatformPkg/PlatformPei/PlatformPeim.inf 9.14ms INFO - 19/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf 13.97ms INFO - 20/22 ./ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf 9.92ms INFO - 21/22 ./ArmPlatformPkg/PrePi/PeiMPCore.inf 12.01ms INFO - 22/22 ./ArmPlatformPkg/PrePi/PeiUniCore.inf 18.06ms INFO - CSpell: Files checked: 22, Issues found: 0 in 0 files INFO - ------------------------------------------------ INFO - --------------Cmd Output Finished--------------- INFO - --------- Running Time (mm:ss): 00:01 ---------- INFO - ----------- Return Code: 0x00000000 ------------ INFO - ------------------------------------------------ PROGRESS - --->Test Success: Spell Check Test NO-TARGET -------Log end--------- As shown, in the "ArmPlatformPkg/**/*.c" expression, "**" is evaluated as= a single directory instead of any number of directories. This can be fix= ed by: =C2=A0- setting the globstar variable (tried on bash): "shopt -s globstar= ", run "shopt globstar" to check its value, or =C2=A0- modifying .pytool/Plugin/SpellCheck/SpellCheck.py to add quotes a= round the files to check so that cspell evaluates the "**" by itself. Thi= s solution seems better as it doesn't require to modify the environment. Regards, Pierre On 6/14/21 7:34 PM, Kun Qin via groups.io wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3445 > > This patch series is a follow up of previous submission: > https://edk2.groups.io/g/devel/message/76419 > > v2 patches mainly focus on feedback for reviewed commits in v1 patches, > including: > a. Adding "Reviewed-by" tags for applicable patches; > b. Adding "Signed-Off-by" tags for myself for all patches; > > Patch v2 branch: https://github.com/kuqin12/edk2/tree/node_14_v2 > > Cc: Sean Brogan > Cc: Bret Barkelew > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > > Kun Qin (1): > Azurepipeline: SpellCheck: Enforce Node dependency to use version 14.= x > > Sean Brogan (3): > StandaloneMmPkg: Core: Spelling error in comment > ArmPlatformPkg: SpellCheck: Switch spellcheck CI to AuditOnly > ArmPkg: SpellCheck: Update valid acronyms in ExtendedWords > > StandaloneMmPkg/Core/Dispatcher.c | 2 +- > .azurepipelines/templates/spell-check-prereq-steps.yml | 2 +- > ArmPkg/ArmPkg.ci.yaml | 19 ++++++++++= +++++++++ > ArmPlatformPkg/ArmPlatformPkg.ci.yaml | 2 +- > 4 files changed, 22 insertions(+), 3 deletions(-) >