From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alexa-out-sd-02.qualcomm.com (alexa-out-sd-02.qualcomm.com [199.106.114.39]) by mx.groups.io with SMTP id smtpd.web10.19371.1670256666546160323 for ; Mon, 05 Dec 2022 08:11:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@quicinc.com header.s=qcdkim header.b=ZojTPnUB; spf=permerror, err=parse error for token &{10 18 %{ir}.%{v}.%{d}.spf.has.pphosted.com}: invalid domain name (domain: quicinc.com, ip: 199.106.114.39, mailfrom: quic_rcran@quicinc.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1670256666; x=1701792666; h=from:message-id:date:mime-version:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=+DPHR4e8AF773gwFOhDXXQgWIpf/Mrw85PW3Vhb3SDQ=; b=ZojTPnUB+B594H3SyVMdKkFMYZCa0xUiocQtDCWbYNqR2121ED1z0tBb LwVQ/eVOlqKcUnNHDekOCZssij29OfkOcCQXNUhuHIPd3Rwpp/U5D3+uH 0hfQ0m0AuEPNlspxE4il43n97qLUysMzo+xxi6xD8ozNmAfuCRswq4WoT M=; Received: from unknown (HELO ironmsg04-sd.qualcomm.com) ([10.53.140.144]) by alexa-out-sd-02.qualcomm.com with ESMTP; 05 Dec 2022 08:11:06 -0800 From: "Rebecca Cran" X-QCInternal: smtphost Received: from nasanex01b.na.qualcomm.com ([10.46.141.250]) by ironmsg04-sd.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 08:11:05 -0800 Received: from [10.110.8.230] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.36; Mon, 5 Dec 2022 08:11:05 -0800 Message-ID: Date: Mon, 5 Dec 2022 09:11:04 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo To: "devel@edk2.groups.io" , "abner.chang@amd.com" , "Rebecca Cran (QUIC)" , "nicklew@nvidia.com" CC: Igor Kulchytskyy , Nick Ramirez References: <20221201032927.226-1-nicklew@nvidia.com> <6c29cc89-5186-985f-e950-00440612a91e@quicinc.com> In-Reply-To: Return-Path: rebecca@quicinc.com X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01b.na.qualcomm.com (10.46.141.250) Content-Language: en-US Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sorry, yes I replied to the wrong email thread. Thanks! -- Rebecca Cran On 12/5/22 09:00, Chang, Abner via groups.io wrote: > [AMD Official Use Only - General] > > Hi Rebecca, > I think you replied to the wrong email thread? This is the typo fix on the edk2-staing but not the one you contributed to RedfishPkg. > > But yes, I tried to have a PR from your branch to edk2 in order to merge the patch from your repo, however, the PR is out of date and I can't have a rebase on your branch. So I cherry pick the change from your branch and created a PR from my personal GitHub. > So your change is merged to edk2 now, please just ignore this error message. Or does it require my actions to fix the error? > > Thanks for the helps on this. > Abner > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Monday, December 5, 2022 11:17 PM >> To: devel@edk2.groups.io; Chang, Abner ; >> nicklew@nvidia.com >> Cc: Igor Kulchytskyy ; Nick Ramirez >> >> Subject: Re: [edk2-devel] [edk2-staging][PATCH V2] edk2- >> staging/RedfishClientPkg: Fix typo >> >> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >> >> >> Hi Abner, >> >> I see you created a PR for this change. But >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith >> ub.com%2Ftianocore%2Fedk2%2Fpull%2F3712&data=05%7C01%7Cabn >> er.chang%40amd.com%7C2751d64c172f465f91f308dad6d3bb0b%7C3dd8961f >> e4884e608e11a82d994e183d%7C0%7C0%7C638058502132324738%7CUnknow >> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha >> WwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RHJ7YdPlTwgLE9K >> Mm%2Fm9pd%2B2pNRyTygsg5ZxpKCli1M%3D&reserved=0 is failing >> with a strange error, and I don't have the setting it's talking about so >> something seems to have gone wrong. >> >> "The merge-queue pull request can't be update >> Details: `Pull request can't be updated with latest base branch changes >> >> Mergify needs the author permission to update the base branch of the pull >> request. >> @bcran needs to authorize modification on its head branch. >> err-code: 85842`" >> >> -- >> Rebecca Cran >> >> On 11/30/22 20:30, Chang, Abner via groups.io wrote: >>> [AMD Official Use Only - General] >>> >>> Reviewed-by: Abner Chang >>> >>>> -----Original Message----- >>>> From: devel@edk2.groups.io On Behalf Of >> Nickle >>>> Wang via groups.io >>>> Sent: Thursday, December 1, 2022 11:29 AM >>>> To: devel@edk2.groups.io >>>> Cc: Chang, Abner ; Igor Kulchytskyy >>>> ; Nick Ramirez >>>> Subject: [edk2-devel] [edk2-staging][PATCH V2] edk2- >>>> staging/RedfishClientPkg: Fix typo >>>> >>>> Caution: This message originated from an External Source. Use proper >>>> caution when opening attachments, clicking links, or responding. >>>> >>>> >>>> Fix typo in RedfishPlatformConfigImpl.c >>>> >>>> Signed-off-by: Nickle Wang >>>> Cc: Abner Chang >>>> Cc: Igor Kulchytskyy >>>> Cc: Nick Ramirez >>>> --- >>>> RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 >> +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git >>>> a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> index 525e666b6c..b2bb5f64e4 100644 >>>> --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> +++ >> b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c >>>> @@ -1,6 +1,6 @@ >>>> /** @file >>>> >>>> - The implementation of EDKII Redfidh Platform Config Protocol. >>>> + The implementation of EDKII Redfish Platform Config Protocol. >>>> >>>> (C) Copyright 2021-2022 Hewlett Packard Enterprise Development >>>> LP
>>>> >>>> -- >>>> 2.38.1.windows.1 >>>> >>>> >>>> >>>> >>>>