From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74])
 by mx.groups.io with SMTP id smtpd.web10.17870.1585330519699180102
 for <devel@edk2.groups.io>;
 Fri, 27 Mar 2020 10:35:20 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=CB3ZRUHl;
 spf=pass (domain: redhat.com, ip: 216.205.24.74, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1585330518;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=5/ClyX9jmdsxe1KAjHx/ewuYTYQJjl4xQNpVuMIyGz4=;
	b=CB3ZRUHleJDlq5PaGYIOx1BX+NAqqDLa6oaoEt75hMjRk6ruk4M8hqu0LmeGhzAinQkaUp
	GjMVyq+n+yG7Oh3L8DqzasWZyhRuNXKXb7/6woXspD0in1AMBwfEkTNvuLfk8oCfO2B13m
	7ibS9jUh7cnpqRrx93VSVWixobJ8o+w=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-399-RBdPmHN9NaeFYhS1viXVYg-1; Fri, 27 Mar 2020 13:35:08 -0400
X-MC-Unique: RBdPmHN9NaeFYhS1viXVYg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 01A5A8018A8;
	Fri, 27 Mar 2020 17:35:07 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-36.ams2.redhat.com [10.36.114.36])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 30A985E016;
	Fri, 27 Mar 2020 17:35:04 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 8/8] CryptoPkg/BaseCryptLib: Use Pcd to control the SHA1 enablement
To: devel@edk2.groups.io, jian.j.wang@intel.com,
 "Gao, Zhichao" <zhichao.gao@intel.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "Lu, XiaoyuX" <xiaoyux.lu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
 Jiewen Yao <jiewen.yao@intel.com>, Ray Ni <ray.ni@intel.com>
References: <20200327015629.2588-1-zhichao.gao@intel.com>
 <20200327015629.2588-9-zhichao.gao@intel.com>
 <E92EE9817A31E24EB0585FDF735412F5B9EEFF0E@ORSMSX113.amr.corp.intel.com>
 <c87a06d14eac4a0094b0e7d4bf10314f@intel.com>
 <D827630B58408649ACB04F44C510003625A33AFC@SHSMSX107.ccr.corp.intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <d3581930-1863-b524-abe5-d2e996468159@redhat.com>
Date: Fri, 27 Mar 2020 18:35:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <D827630B58408649ACB04F44C510003625A33AFC@SHSMSX107.ccr.corp.intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Hi All,

On 03/27/20 03:51, Wang, Jian J wrote:
> Zhichao,
>
> You can just use the PCD in C code "if (PcdGet...){}" instead of macro
> #if.

I do not have the capacity to contribute useful thoughts to this
discussion right now; I just want to provide three links here, to
previous comments that seem related:

  https://edk2.groups.io/g/devel/message/53581
  https://edk2.groups.io/g/devel/message/53587
  https://edk2.groups.io/g/devel/message/53588

Alternative links to the same:

  http://mid.mail-archive.com/e68a3ba1-f469-8ac3-c1e7-78a51bdaf291@redhat.com
  http://mid.mail-archive.com/E92EE9817A31E24EB0585FDF735412F5B9E81876@ORSMSX113.amr.corp.intel.com
  http://mid.mail-archive.com/b1db8f28-524d-0917-b54d-f6a15c497118@redhat.com

Thanks,
Laszlo