From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5178021103996 for ; Tue, 28 Aug 2018 18:35:35 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 18:35:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,300,1531810800"; d="scan'208";a="84214917" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.8]) ([10.239.9.8]) by fmsmga004.fm.intel.com with ESMTP; 28 Aug 2018 18:35:29 -0700 To: shenglei , edk2-devel@lists.01.org Cc: Jaben Carsey , Laszlo Ersek References: <20180828034257.19060-1-shenglei.zhang@intel.com> <20180828034257.19060-14-shenglei.zhang@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Wed, 29 Aug 2018 09:36:16 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180828034257.19060-14-shenglei.zhang@intel.com> Subject: Re: [PATCH v3 13/16] ShellPkg/Shell: Remove unused PCDs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 01:35:36 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/28/2018 11:42 AM, shenglei wrote: > The PCDs below are unused, so they have been removed from inf. > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize > gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength > > Cc: Jaben Carsey > Cc: Ruiyu Ni > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: shenglei > Reviewed-by: Ruiyu Ni > --- > ShellPkg/Application/Shell/Shell.inf | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/ShellPkg/Application/Shell/Shell.inf b/ShellPkg/Application/Shell/Shell.inf > index d89f85bb76..83049844d6 100644 > --- a/ShellPkg/Application/Shell/Shell.inf > +++ b/ShellPkg/Application/Shell/Shell.inf > @@ -102,10 +102,8 @@ > gEfiShellPkgTokenSpaceGuid.PcdShellRequireHiiPlatform ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupportFrameworkHii ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPageBreakDefault ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellInsertModeDefault ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellScreenLogCount ## CONSUMES > - gEfiShellPkgTokenSpaceGuid.PcdShellMapNameLength ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellPrintBufferSize ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellForceConsole ## CONSUMES > gEfiShellPkgTokenSpaceGuid.PcdShellSupplier ## CONSUMES > Reviewed-by: Ruiyu Ni -- Thanks, Ray