From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id BC191AC13B0 for ; Tue, 14 Nov 2023 15:01:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Z43ab6NJ3tVA2KDRJSaKb0Yt/s2VEXhOSy6iIr0brw0=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699974104; v=1; b=eBjsY4/Ix6EBsfz7gFbUrBNcuKX1kiysvBqDfUWiVpXQrz0TeUUu30VRrYavx2017Jeng5MR L1U8mX5gwW/ky97kujfzJOGX1XQBkyYm6srDmT6RQY5rDDDJ2x2S0PNRuUQUA0BsLwAaHPpC077 wIw18+SwX6mgFmpONir1qGZ0= X-Received: by 127.0.0.2 with SMTP id PAtEYY7687511x7sPAmsDqgD; Tue, 14 Nov 2023 07:01:44 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.14703.1699974103660522577 for ; Tue, 14 Nov 2023 07:01:43 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-stKzQ4jWMdux52pM8hjrQg-1; Tue, 14 Nov 2023 10:01:40 -0500 X-MC-Unique: stKzQ4jWMdux52pM8hjrQg-1 X-Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B8A72999B5E; Tue, 14 Nov 2023 15:01:20 +0000 (UTC) X-Received: from [10.39.194.106] (unknown [10.39.194.106]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E96F492BFE; Tue, 14 Nov 2023 15:01:19 +0000 (UTC) Message-ID: Date: Tue, 14 Nov 2023 16:01:18 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: Pedro Falcato , Rebecca Cran Cc: devel@edk2.groups.io, mikuback@linux.microsoft.com, Michael Kinney , Andrew Fish , Marcin Juszkiewicz , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> <23dd696a-52a1-4c26-bfb6-5b5587325c42@linux.microsoft.com> <30e9b11c-ab39-4266-8981-5242542b625d@bsdio.com> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: JUlLMxQPAEvFGDFq1yAKFYP4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="eBjsY4/I"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/13/23 22:33, Pedro Falcato wrote: > On Mon, Nov 13, 2023 at 8:37 PM Rebecca Cran wrote: >> >> On 11/13/2023 1:08 PM, Michael Kubacki wrote: >>> Yes. I just did it. It is relatively minor and impacts expected code >>> areas. >>> >>> https://github.com/tianocore/edk2/pull/5043/files >> >> >> Could you update .git-blame-ignore-revs please? > > You can't do that until the merge is done, since we use > rebase-and-merge for tianocore (and rebases do not keep stable commit > hashes). > But I would plead that this should not get merged in general :/ Seeing the cumulative diff in that PR, do you have specific counter-arguments? The diff is trivial, IMO. You mentioned "error prone" and "much churn", which are very valid concerns, but they don't seem to apply here. We can review a diff of this size (especially if it's split up on Pkg boundaries), and the github view indicates the change is only in whitespace amount. The change in "OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c" is a net win; the current formatting is really distracting. Furthermore, this diff actually highlights some inexplicable syntax in "EmulatorPkg/FvbServicesRuntimeDxe/FvbInfo.c": those backslashes (not parts of any macro definition) are an eyesore. They should be fixed regardless of re-uncrustification. The version N vs. N+1 concern shouldn't be one; the authoritative version is what the YAML file in edk2 says. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111201): https://edk2.groups.io/g/devel/message/111201 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-