public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Mark Kettenis" <mark.kettenis@xs4all.nl>
To: Mark Kettenis <kettenis@openbsd.org>
Cc: devel@edk2.groups.io, ardb+tianocore@kernel.org,
	leif@nuviainc.com, pete@akeo.ie, jeremy.linton@arm.com,
	kettenis@openbsd.org
Subject: Re: [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute
Date: Sun, 10 Oct 2021 22:15:06 +0200 (CEST)	[thread overview]
Message-ID: <d3ca4c69399121be@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <20211010194814.17129-1-kettenis@openbsd.org> (message from Mark Kettenis on Sun, 10 Oct 2021 21:48:14 +0200)

Sorry. Used an old mail address for ardb.  Can resend this if necessary.

> From: Mark Kettenis <kettenis@openbsd.org>
> Date: Sun, 10 Oct 2021 21:48:14 +0200
> 
> The MMIO host bridge window isn't translated as both the primary
> and secondary side are MMIO.  So remove the incorrect
> TypeTranslation attribute.
> 
> Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> ---
>  Platform/RaspberryPi/AcpiTables/Pci.asl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Pci.asl b/Platform/RaspberryPi/AcpiTables/Pci.asl
> index ee37b7a21e..f485c6b5d2 100644
> --- a/Platform/RaspberryPi/AcpiTables/Pci.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Pci.asl
> @@ -94,7 +94,7 @@ DefinitionBlock (__FILE__, "SSDT", 5, "RPIFDN", "RPI4PCIE", 2)
>              1,                              // SANITIZED_PCIE_MMIO_LEN + SANITIZED_PCIE_PCI_MMIO_BEGIN
>              SANITIZED_PCIE_CPU_MMIO_WINDOW, // SANITIZED_PCIE_PCI_MMIO_BEGIN - SANITIZED_PCIE_CPU_MMIO_WINDOW
>              2                               // SANITIZED_PCIE_MMIO_LEN + 1
> -            ,,,MMI1,,TypeTranslation
> +            ,,,MMI1
>            )
>  
>            // root port registers, not to be used if SMCCC is utilized
> -- 
> 2.33.0
> 
> 

  reply	other threads:[~2021-10-10 20:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-10 19:48 [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute Mark Kettenis
2021-10-10 20:15 ` Mark Kettenis [this message]
2021-10-10 21:10 ` [edk2-devel] " Ard Biesheuvel
2021-10-14 21:05   ` Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3ca4c69399121be@bloch.sibelius.xs4all.nl \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox