From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D9C3AD811A4 for ; Fri, 2 Feb 2024 14:10:31 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=sNsALGwg0tgFXBg5bsJBBN5HVftr5GJW0b5121SdCKg=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706883030; v=1; b=BxiWWhhhGTuOMgt1zlXWlFq5OmbDPihHfyXcxkKtTNGrDqpWOgv24W4Lj4MesNY9CzLAQRCN unVtcGXb1adzoVZ4P1Vlz8sJdsyXeZUeEk7nKxol/TXv0auVovP2L4pAX4a1AphXQQkeR1uEWV1 0ymO/13gCj3qZnsl2LEaMDOY= X-Received: by 127.0.0.2 with SMTP id X4wMYY7687511xd3Bzq0gxH7; Fri, 02 Feb 2024 06:10:30 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.23469.1706883029874385105 for ; Fri, 02 Feb 2024 06:10:30 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-EiWxpLVuObGdRNXdLxxnfg-1; Fri, 02 Feb 2024 09:10:24 -0500 X-MC-Unique: EiWxpLVuObGdRNXdLxxnfg-1 X-Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4E64185A782; Fri, 2 Feb 2024 14:10:22 +0000 (UTC) X-Received: from [10.39.192.34] (unknown [10.39.192.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 478BC2166B33; Fri, 2 Feb 2024 14:10:19 +0000 (UTC) Message-ID: Date: Fri, 2 Feb 2024 15:10:14 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v8 00/37] Enable LoongArch virtual machine in edk2 To: "Ni, Ray" , "devel@edk2.groups.io" , "lichao@loongson.cn" Cc: "Kinney, Michael D" , Liming Gao , "Liu, Zhiguang" , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Sami Mujawar , "Yao, Jiewen" , "Justen, Jordan L" , "Warkentin, Andrei" , Sunil V L , Bibo Mao References: <17ADD1C0483F8D84.24595@groups.io> <17ADD29C1061FE55.11113@groups.io> <8714203c-74e8-4915-b41b-711d5e973265@loongson.cn> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: FN3qsd43SO0kvdAI4hpJ0VO4x7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BxiWWhhh; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/2/24 04:36, Ni, Ray wrote: > Chao, > > When I review the detailed changes, I found a generic issue: > >   Some changes to INF files are not necessary. They are just reordering > the source files or libs within the same section. I'm myself a bit torn about this. I generally like to keep entries in [LibraryClasses] etc lexicographically sorted. However, it indeed becomes confusing when a lib class is added or removed *together* with sorting the entire list afresh. I think such changes are worth splitting in to: first, sort the entries (a no-op patch), then implement the change. > >   I hope that you could avoid these unnecessary changes. I wouldn't necessarily call them unnecessary. I think sorting / cleanups are worthwhile, but they should be well separated from the other types of changes. >   Another point is please make sure do not add unnecessary lib > dependencies for x86 (e.g.: SafeIntLib). That might cause >   some platform build breaks due to not including the SafeIntLib in DSC. Can you clarify? SafeIntLib is generally a good idea to *use* in C code, and when one uses it, it must be listed in [LibraryClasses]. I agree that, when we extend an INF file with a new dependency, we should grep edk2 (at least) for platform DSCs that refer to that INF, and see if we have to resolve the lib class. Of course, when the C code doesn't actually consume SafeIntLib APIs, then listing SafeIntLib in the INF file is just a bug. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115048): https://edk2.groups.io/g/devel/message/115048 Mute This Topic: https://groups.io/mt/103971622/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-