From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.20; helo=mga02.intel.com; envelope-from=star.zeng@intel.com; receiver=edk2-devel@lists.01.org Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BA747211B739C for ; Tue, 15 Jan 2019 01:53:06 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2019 01:53:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,481,1539673200"; d="scan'208";a="311931907" Received: from shzintpr01.sh.intel.com (HELO [10.253.24.32]) ([10.239.4.80]) by fmsmga005.fm.intel.com with ESMTP; 15 Jan 2019 01:53:04 -0800 To: Laszlo Ersek , edk2-devel@lists.01.org Cc: Hao Wu , Michael D Kinney , Ray Ni , Liming Gao , star.zeng@intel.com References: <1547479196-40248-1-git-send-email-star.zeng@intel.com> <1547479196-40248-9-git-send-email-star.zeng@intel.com> <36a8201d-afdf-cc61-d824-56373ce35f9f@redhat.com> From: "Zeng, Star" Message-ID: Date: Tue, 15 Jan 2019 17:52:34 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <36a8201d-afdf-cc61-d824-56373ce35f9f@redhat.com> Subject: Re: [PATCH V2 08/15] MdeModulePkg Variable: Add emulated variable NV mode support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Jan 2019 09:53:06 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2019/1/15 17:33, Laszlo Ersek wrote: > On 01/14/19 16:19, Star Zeng wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1323 >> Merge EmuVariable and Real variable driver. >> >> Add emulated variable NV mode support in real variable driver. >> Platform can configure PcdEmuVariableNvModeEnable statically >> (build time) or dynamically (boot time) to support emulated >> variable NV mode. >> >> Then EmuVariableRuntimeDxe could be removed, the removal of >> EmuVariableRuntimeDxe will be done after platforms are migrated >> to use the merged variable driver. >> >> Cc: Jian J Wang >> Cc: Hao Wu >> Cc: Michael D Kinney >> Cc: Liming Gao >> Cc: Ray Ni >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Star Zeng >> --- >> .../Universal/Variable/RuntimeDxe/Variable.c | 318 +++++++++++++++------ >> .../Universal/Variable/RuntimeDxe/Variable.h | 1 + >> .../Universal/Variable/RuntimeDxe/VariableDxe.c | 27 +- >> .../Variable/RuntimeDxe/VariableRuntimeDxe.inf | 4 +- >> .../Universal/Variable/RuntimeDxe/VariableSmm.c | 29 +- >> .../Universal/Variable/RuntimeDxe/VariableSmm.inf | 4 +- >> 6 files changed, 271 insertions(+), 112 deletions(-) > > Acked-by: Laszlo Ersek > > (I think that this work and Ard's standalone MM refactoring will > conflict. If that's the case then I guess one of the patch sets should > be rebased. I seem to recall that this was already discussed on the list.) Yes, right. I have been aware of the conflict, and I have notified it at https://lists.01.org/pipermail/edk2-devel/2019-January/034934.html when I sent V1 patches. Thanks, Star > > Thanks, > Laszlo >