From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 25C2A225E400F for ; Thu, 22 Mar 2018 21:45:13 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 21:51:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,348,1517904000"; d="scan'208";a="214132649" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.4]) ([10.239.9.4]) by fmsmga005.fm.intel.com with ESMTP; 22 Mar 2018 21:51:45 -0700 To: edk2-devel@lists.01.org References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> <20180320075446.GH125210@SZX1000114654> <20180320095131.l2k2kk7nuxzv7r66@bivouac.eciton.net> <20180320121520.GI125210@SZX1000114654> From: "Ni, Ruiyu" Message-ID: Date: Fri, 23 Mar 2018 12:51:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180320121520.GI125210@SZX1000114654> Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Mar 2018 04:45:14 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 3/20/2018 8:15 PM, Guo Heyi wrote: > I've no idea about how to use Driver####; let me spend some time to learn first > :) Heyi, you could use "load xxxDriver.efi" to load the dynamic command in shell. After that, you can run "tftp" in shell just as running an internal command. > > Regards, > > Heyi > > On Tue, Mar 20, 2018 at 09:51:32AM +0000, Leif Lindholm wrote: >> Ah, apologies. >> >> I would be reluctant to add commands not covered by the UEFI Shell >> Specification by default. >> >> Since it is now a dynamic command, is there any way of loading this >> dynamically (perhaps via DRIVER####) where you feel the need for it? >> >> / >> Leif >> >> On Tue, Mar 20, 2018 at 03:54:46PM +0800, Guo Heyi wrote: >>> Ping :) >>> >>> >>> On Wed, Mar 07, 2018 at 04:02:30PM +0000, Ard Biesheuvel wrote: >>>> On 7 March 2018 at 03:03, Heyi Guo wrote: >>>>> Since D0x platforms always have network enabled, we would like to >>>>> enable tftp command by default so that we can download something in >>>>> EFI Shell. >>>>> >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>> Signed-off-by: Heyi Guo >>>>> Cc: Ard Biesheuvel >>>>> Cc: Leif Lindholm >>>> >>>> The first patch looks fine to me, but I would like to give Leif a >>>> chance to comment on the policy side of this patch. >>>> >>>> Please ping us by the end of next week if we haven't responded by then. >>>> >>>>> --- >>>>> Platform/Hisilicon/D03/D03.dsc | 2 ++ >>>>> Platform/Hisilicon/D05/D05.dsc | 1 + >>>>> 2 files changed, 3 insertions(+) >>>>> >>>>> diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc >>>>> index cb0669d639d1..fce1e60b1275 100644 >>>>> --- a/Platform/Hisilicon/D03/D03.dsc >>>>> +++ b/Platform/Hisilicon/D03/D03.dsc >>>>> @@ -29,6 +29,8 @@ [Defines] >>>>> SKUID_IDENTIFIER = DEFAULT >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf >>>>> >>>>> + DEFINE INCLUDE_TFTP_COMMAND = TRUE >>>>> + >>>>> !include Silicon/Hisilicon/Hisilicon.dsc.inc >>>>> >>>>> [LibraryClasses.common] >>>>> diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc >>>>> index 8373a821a496..f007f3d2d7e8 100644 >>>>> --- a/Platform/Hisilicon/D05/D05.dsc >>>>> +++ b/Platform/Hisilicon/D05/D05.dsc >>>>> @@ -29,6 +29,7 @@ [Defines] >>>>> SKUID_IDENTIFIER = DEFAULT >>>>> FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf >>>>> DEFINE EDK2_SKIP_PEICORE=0 >>>>> + DEFINE INCLUDE_TFTP_COMMAND = TRUE >>>>> DEFINE NETWORK_IP6_ENABLE = FALSE >>>>> DEFINE HTTP_BOOT_ENABLE = FALSE >>>>> >>>>> -- >>>>> 2.7.4 >>>>> > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > -- Thanks, Ray