From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.2010.1590050240144575210 for ; Thu, 21 May 2020 01:37:20 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A9157D6E; Thu, 21 May 2020 01:37:18 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.250]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F1C543F52E; Thu, 21 May 2020 01:37:16 -0700 (PDT) Subject: Re: [PATCH 0/3] OvmfPkg/Tcg2ConfigPei: fix ARM/AARCH64 build failure To: Laszlo Ersek , edk2-devel-groups-io Cc: Eric Auger , Jordan Justen , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Simon Hardy , Stefan Berger References: <20200520225841.17793-1-lersek@redhat.com> From: "Ard Biesheuvel" Message-ID: Date: Thu, 21 May 2020 10:37:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200520225841.17793-1-lersek@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/21/20 12:58 AM, Laszlo Ersek wrote: > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2728 > Repo: https://pagure.io/lersek/edk2.git > Branch: restrict_tpm12_to_x86_bz_2728 >=20 > Another regression fix for edk2-stable202005. >=20 > End of February 2020, Ard and Marc-Andr=C3=A9 worked on two TPM-related > features in parallel. Respectively: >=20 > - [edk2-devel] [PATCH v4 00/11] > ArmVirtPkg: implement measured boot for ArmVirtQemu >=20 > http://mid.mail-archive.com/20200227144056.56988-1-ard.biesheuvel@li= naro.org > https://edk2.groups.io/g/devel/message/55004 >=20 > - [edk2-devel] [PATCH v4 0/5] > Ovmf: enable TPM 1.2 >=20 > http://mid.mail-archive.com/20200226152433.1295789-1-marcandre.lurea= u@redhat.com > https://edk2.groups.io/g/devel/message/54894 >=20 > Both series were merged tightly one after the other. There was no merge > conflict, and standing alone (without rebasing one on the other), each > series was self-contained and correct. Their combination however led to > an ArmVirtQemu build regression. There never was an intent to support > TPM-1.2 in ArmVirtQemu, but the TPM-1.2 series for OVMF kind of made > that "mandatory". >=20 > Worse, the build regression has remained hidden for 2+ months because > (a) I didn't expect Marc-Andr=C3=A9's series to affect any ArmVirtPkg > platform, (b) my ArmVirtQemu build script did not set TPM2_ENABLE. >=20 > This series fixes the build regression, and intends no functional > changes at all. >=20 > Functional regression-testing would be appreciated: >=20 > - from Simon regarding their TPM-1.2 passthrough use case, >=20 > - from Marc-Andr=C3=A9 regarding vTPM-2.0 on X64, >=20 > - from Eric regarding vTPM-2.0 on AARCH64. >=20 > This is a regression fix, therefore it is eligible for merging during > the edk2-stable202005 Hard Feature Freeze too > . >=20 > If you plan to regression-test this series, then please say so soon, > otherwise I wouldn't like to wait for long -- assuming an R-b from Ard > or Jordan -- even without Tested-by's. >=20 > In the future we should likely set some "-D" flags somewhere under > "ArmVirtPkg/PlatformCI/" (so that our CI coverage grow). The best I can > personally do about that is maybe file a BZ?... >=20 Thanks a lot for fixing this. I know TPM support is not a feature you=20 care deeply about. For the series, Reviewed-by: Ard Biesheuvel Tested-by: Ard Biesheuvel (on AArch64 only)