From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by mx.groups.io with SMTP id smtpd.web10.53934.1681735546702325701 for ; Mon, 17 Apr 2023 05:45:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@freebsd.org header.s=dkim header.b=mDosLiHl; spf=pass (domain: freebsd.org, ip: 96.47.72.81, mailfrom: corvink@freebsd.org) Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4Q0Rc93zR0z4Z9W; Mon, 17 Apr 2023 12:45:45 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q0Rc92js8z483L; Mon, 17 Apr 2023 12:45:45 +0000 (UTC) (envelope-from corvink@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681735545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KT9WfUcG5OrgzXhFvU7DTjlos6suFhK6MM0VPQoN3sk=; b=mDosLiHlcimmeRF62I0glmeR74RCSaIdFz9OkhNYrSQOB+krUhsjLflpyQFUvgPGDyCFz4 Tcc0R12LgxR34kMSDgMsKQVkPX58A+Zee/DKSxM1F0vgs5bzrqCCh8II/ggdUTlvR0Bm1T 3HalyW0cFCJTMUx434uh//7dBZRf0QS2f2QlELBsPFeON2irZK/uj2FPIchlsPpW3Xfmq6 jkRFdZuUwRgNZ0mq1vuIv4/t+qd/5/2jvpyMQPzCDaoRq/k3aPKl4mgss+AjPaDNk69OFV QRBrCO9K0QF7WSG3RlHjnR9CSTxJZK2Xv/MLWH7DwLgVkJ8MKAwprqw9oB7JIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1681735545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KT9WfUcG5OrgzXhFvU7DTjlos6suFhK6MM0VPQoN3sk=; b=mNDxuB7HAx3be3vKeK8QDdQIxeDwfn6WzQyup8nwPFAcKAKn3rfEIj5QQ5MNXYmkSRdDqk 2OAN6eUyQjB3lo00ADaDdnssS58pGrFCySsdwbhNHdV7efqV1hpXkeOct4LgJJKbeK9IzN fjiZs26DHeNU2Vn4CORccxi5e84OWisfIVy2uwTkDOEkpajWUcCw0fabNaesCOu0TKmNG4 RzWHX8utsCJ+Ap/M21WJ+u9qA5RdcgxhVU37emEpHNo8ereeSBbUrn6WCADAJ4z29Fn6UL nlMEriLZkijQ6o8Y3Fak66ZkJfA9KJAwrxOTGNOTIaLTIskRSZgxpbT6jibvvQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1681735545; a=rsa-sha256; cv=none; b=YdjwAVqBGb722dGrL/rK8tlPIusakABgEkQc4kPPKO5OEhszJDS7TAtLDxzHkXhuh+h5KQ 3p3GnbRyLHFJfRszaOKpttErP2z2hHrkUUnTU9Ifsbns/mIKHI38X+APuljs5iz7p4v8Is 2nyQIIAFXeqxWzkAuZwwzmz5aM86nAVoIVFUz93zInBFjHRwHibVpqEh4lI86vHdSXdMUO mqlsT8rJ4aRNgTc/I7EKEsXMBO26EqL/2mQG7O07dZN1fSYk7CqJLWV7ntW/UZsORtnIIQ zi4GCZc4/NY4dMY3uFARG3PdNewEaAnfywh1abpspMFd8UiPChsvNHtIfw6Bwg== Received: from [172.21.178.239] (unknown [195.226.174.194]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: corvink) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Q0Rc76CdwzZ4l; Mon, 17 Apr 2023 12:45:43 +0000 (UTC) (envelope-from corvink@FreeBSD.org) Message-ID: Subject: Re: [PATCH 1/1] OvmfPkg/BhyveBhf: install bhyve's ACPI tables From: =?UTF-8?B?Q29ydmluIEvDtmhuZQ==?= To: Gerd Hoffmann Cc: devel@edk2.groups.io, Michael D Kinney , Liming Gao , Zhiguang Liu , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Rebecca Cran , Peter Grehan Date: Mon, 17 Apr 2023 14:45:41 +0200 In-Reply-To: References: <20230417114601.398383-1-corvink@FreeBSD.org> User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-Groupsio-MsgNum: 103102 Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-QziZ9sNqfTVk+Mm7pOTV" --=-QziZ9sNqfTVk+Mm7pOTV Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-04-17 at 14:14 +0200, Gerd Hoffmann wrote: > On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin K=C3=B6hne wrote: > > It's much easier to create configuration dependend ACPI tables for > > bhyve > > than for OVMF. For this reason, don't use the statically created > > ACPI > > tables provided by OVMF. Instead prefer the dynamically created > > ACPI > > tables of bhyve. If bhyve provides no ACPI tables or we are unable > > to > > detect those, fall back to OVMF tables. > >=20 > > Ideally, we use the qemu fwcfg interface to pass the ACPI tables > > from > > bhyve to OVMF. bhyve will support this in the future. However, > > current > > bhyve executables don't support passing ACPI tables by the qemu > > fwcfg > > interface. They just copy the ACPI into main memory. For that > > reason, > > pick up the ACPI tables from main memory. > >=20 > > Implementation is similar to OvmfPkg/XenAcpiPlatformDxe/Xen.c. >=20 > Can both Xen and Bhyve share the same implementation? >=20 > Given in both cases RAM is scanned for the RSDP I'd expect it should > not be very hard and we avoid duplicating the code. >=20 > take care, > =C2=A0 Gerd >=20 Hi Gerd, thanks for your reply. It's mostly the same code. Only the start and end of the scanned range differ. So, it does make sense to share the same implementation. Where's the right place for this shared implementation? Is it "OvmfPkg/Library"? --=20 Kind regards, Corvin --=-QziZ9sNqfTVk+Mm7pOTV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgvRSla3m2t/H2U9G2FTaVjFeAmoFAmQ9P3YACgkQ2FTaVjFe AmpykxAApbi/7Kll2zeaS54boWNYf9MIr4iyXtReJFqpzz6K1IGfVGzvB5IEOtuH MjJZt8gwIyHl9qLjz8DPaSouybeJJ6Uq9S5xh83wkankFZAQNOu5rzdtzsZ9/ZjZ qDbHxN3/Wtj9+JeHyBFDNAq9UPImtmWyWAei7i99jDTtI1E+ScncUqrD9JYn2F6a FJrdmPYHg+LAT9nWvU2fQfV4PGP1MnBHPQfZ8nCq26bllQNYcalAAMzhYyBjJzCC O4OBy9SzxkNwz9k5OWO4V//HbzV6KcP+7QAlXfmchbM+rtjdl61uBe5bOl+cg29k Ee6z9ioe9j0jo7/nniR7xRg3GVs/DlhnAqoEqa1F0Q2REaBuD9SYqZS1MCYPpFFP wLsFEiO4DI1oX307f65XWQjA6s1bXJRLF2FZ/Bvx/GFIXJ69gUmzmVkLTpCHZcby FVy92+/fq4hijrl6IuuTNtnj37LFnKFyxmc3c7hwFBVv1NYmFMzsSffjkCrMjkW+ bfeS+8jF5Ieef+X7pR10//LJn1VjI0F6mNrN3Px0SMfw5AxZaLYxe7CWw0bFvSIV qoEPkat5Lu3rPFArlwu5OoTz7zQHhkDaiU/lgVUD3UGNWBJqoafqsty05hG5PIm5 0Vw7UykPMyW2ZX2VUt3J2SH07IFpb0nYHU/Alrs4M0oLSm6qYcY= =GFbS -----END PGP SIGNATURE----- --=-QziZ9sNqfTVk+Mm7pOTV--