public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>,
	"leif@nuviainc.com" <leif@nuviainc.com>
Cc: Rebecca Cran <rebecca@bsdio.com>, Andrew Fish <afish@apple.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve
Date: Fri, 3 Jul 2020 17:49:21 +0200	[thread overview]
Message-ID: <d4139416-e8ec-af76-ef11-abd63672ff8d@redhat.com> (raw)
In-Reply-To: <MWHPR11MB16300531914E72FB6EE09446806A0@MWHPR11MB1630.namprd11.prod.outlook.com>

On 07/03/20 03:40, Gao, Liming wrote:

> Besides, there is another new checker of ECC to check coding style for each patch. Can you give your comment?
> https://edk2.groups.io/g/devel/message/61966

I've seen that feature.

Importantly, it gives package maintainers package-level exception lists.
So if ECC rejects something, and the package maintainers disagree with
the rejection, they can create an exception inside the package, and
suppress the ECC report.

We don't have the same option with PatchCheck.

(For generated files anyway, that's what I'm suggesting in fact: if
PatchCheck sees the string "@file: generated" in a source file, it
should omit the license check altogether, for that file.)

Thanks!
Laszlo


  parent reply	other threads:[~2020-07-03 15:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 15:38 OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve Rebecca Cran
2020-07-02  9:27 ` Laszlo Ersek
2020-07-02 10:54   ` License Check - was " Leif Lindholm
2020-07-02 13:49     ` [edk2-devel] " Liming Gao
2020-07-02 14:13       ` Leif Lindholm
2020-07-02 14:31         ` Ard Biesheuvel
2020-07-03  1:40           ` Liming Gao
2020-07-03 10:37             ` Leif Lindholm
2020-07-03 15:07               ` Liming Gao
2020-07-03 15:49             ` Laszlo Ersek [this message]
2020-07-07 14:31               ` Liming Gao
2020-07-03  3:13   ` Rebecca Cran
2020-07-03 15:50     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d4139416-e8ec-af76-ef11-abd63672ff8d@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox