From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61])
 by mx.groups.io with SMTP id smtpd.web11.1649.1593791370937711707
 for <devel@edk2.groups.io>;
 Fri, 03 Jul 2020 08:49:31 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=QinPnR2j;
 spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1593791370;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=d5yEAxAMIXQNuYjOFcAuq3Ay5qRZG/A6PmlJtuPRUgE=;
	b=QinPnR2johDOTn4R7ZQyvQBE/VlqDnu877MyC/WNYk0272zcFmJMfVQCqhEGjdfpDdV6R/
	6slciNKQf4GPxCBN6g2KHBjSG1goZR9Ilxbhs6F1RUwosnI1GZ/OcrrP3zrxxLYUsnaWNc
	oc7M2bUYiQxRETKfHNWa9Fnp7dDvTzU=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-322-bvXSkUqnMrmuxjsbvNc-TA-1; Fri, 03 Jul 2020 11:49:26 -0400
X-MC-Unique: bvXSkUqnMrmuxjsbvNc-TA-1
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C53F9800401;
	Fri,  3 Jul 2020 15:49:24 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-238.ams2.redhat.com [10.36.114.238])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E2BB15C221;
	Fri,  3 Jul 2020 15:49:22 +0000 (UTC)
Subject: Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve
To: "Gao, Liming" <liming.gao@intel.com>,
 "devel@edk2.groups.io" <devel@edk2.groups.io>,
 "ard.biesheuvel@arm.com" <ard.biesheuvel@arm.com>,
 "leif@nuviainc.com" <leif@nuviainc.com>
Cc: Rebecca Cran <rebecca@bsdio.com>, Andrew Fish <afish@apple.com>,
 "Justen, Jordan L" <jordan.l.justen@intel.com>,
 "Kinney, Michael D" <michael.d.kinney@intel.com>
References: <92612908-44f4-30d4-ae3a-3ad595e2141f@bsdio.com>
 <68b55c49-1e49-e082-ca38-68c3d321611b@redhat.com>
 <20200702105419.GN6739@vanye>
 <MWHPR11MB1630728265BADEE302D7E2DA806D0@MWHPR11MB1630.namprd11.prod.outlook.com>
 <20200702141323.GQ6739@vanye> <d76520e2-1a47-bb71-15ad-a9f914a36c40@arm.com>
 <MWHPR11MB16300531914E72FB6EE09446806A0@MWHPR11MB1630.namprd11.prod.outlook.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <d4139416-e8ec-af76-ef11-abd63672ff8d@redhat.com>
Date: Fri, 3 Jul 2020 17:49:21 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Firefox/52.0 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <MWHPR11MB16300531914E72FB6EE09446806A0@MWHPR11MB1630.namprd11.prod.outlook.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

On 07/03/20 03:40, Gao, Liming wrote:

> Besides, there is another new checker of ECC to check coding style for each patch. Can you give your comment?
> https://edk2.groups.io/g/devel/message/61966

I've seen that feature.

Importantly, it gives package maintainers package-level exception lists.
So if ECC rejects something, and the package maintainers disagree with
the rejection, they can create an exception inside the package, and
suppress the ECC report.

We don't have the same option with PatchCheck.

(For generated files anyway, that's what I'm suggesting in fact: if
PatchCheck sees the string "@file: generated" in a source file, it
should omit the license check altogether, for that file.)

Thanks!
Laszlo