From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3F27781F1F for ; Thu, 1 Dec 2016 13:51:19 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A58C6624DA; Thu, 1 Dec 2016 21:51:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-138.phx2.redhat.com [10.3.116.138]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uB1LpGZS014311; Thu, 1 Dec 2016 16:51:17 -0500 To: Jiewen Yao , edk2-devel@ml01.01.org References: <1480580607-19928-1-git-send-email-jiewen.yao@intel.com> Cc: Michael D Kinney , Jeff Fan From: Laszlo Ersek Message-ID: Date: Thu, 1 Dec 2016 22:51:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480580607-19928-1-git-send-email-jiewen.yao@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 01 Dec 2016 21:51:18 +0000 (UTC) Subject: Re: [PATCH] MdeModulePkg/PiSmmCore: AllocatePool should use MemoryType. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Dec 2016 21:51:19 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 12/01/16 09:23, Jiewen Yao wrote: > PiSmmCore supports page level protection based upon the Memory Type > (EfiRuntimeServicesCode/EfiRuntimeServicesData) and PE image. > > However, the Memory Type information is ignored in AllocatePool(). > If a caller calls AllocatePool with EfiRuntimeServicesCode, > the final memory is still allocated as EfiRuntimeServicesData. > > This patch supports AllocatePool with EfiRuntimeServicesCode. > > Cc: Jeff Fan > Cc: Michael D Kinney > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > --- > MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 13 ++- > MdeModulePkg/Core/PiSmmCore/Pool.c | 66 +++++++++--- > MdeModulePkg/Core/PiSmmCore/SmramProfileRecord.c | 114 +++++++++++--------- > 3 files changed, 124 insertions(+), 69 deletions(-) series Regression-tested-by: Laszlo Ersek (Please make sure to number the patches in the series next time.) Thanks Laszlo