From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from alto.onthenet.com.au (alto.onthenet.com.au [203.13.68.12]) by mx.groups.io with SMTP id smtpd.web12.1010.1649372268932144180 for ; Thu, 07 Apr 2022 15:57:49 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@nt.com.au header.s=dkim header.b=HJrevRAC; spf=none, err=permanent DNS error (domain: iredmail.onthenet.com.au, ip: 203.13.68.12, mailfrom: srs0=3xoe=ur=freebsd.org=grehan@iredmail.onthenet.com.au) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id E1CBF20A3284 for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id B15F42037396 for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) Authentication-Results: iredmail.onthenet.com.au (amavisd-new); dkim=pass (1024-bit key) reason="pass (just generated, assumed good)" header.d=nt.com.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nt.com.au; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:to:content-language:subject:subject :user-agent:mime-version:date:date:message-id; s=dkim; t= 1649372264; x=1651964265; bh=Vzt7pCOpVaWY6At218TrJWHkzpGA/pz4wJ8 2D+mI5eI=; b=HJrevRACuJAqJ8QPgFLIwDxQhyHx1/j8wYriRLBrDFSxcSBc4kh rDaxom8Er/ffRFcyGXSJ7KpHw0f8L1/75FvbRWmO3HiCzAtgnhv2Xs5X0fy5a0K3 tD8u3qLm9zaoXTP/14gHCDstZELvmASsLv5eTV+bQXDHfT/ru4yRWY1I= Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id c77fE5EUF5S5 for ; Fri, 8 Apr 2022 08:57:44 +1000 (AEST) Received: from [192.168.1.102] (unknown [120.29.51.26]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 669A321141F9; Fri, 8 Apr 2022 08:57:43 +1000 (AEST) Message-ID: Date: Fri, 8 Apr 2022 08:57:43 +1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg To: =?UTF-8?Q?Corvin_K=c3=b6hne?= , Rebecca Cran , "devel@edk2.groups.io" Cc: Ard Biesheuvel , Jiewen Yao , Jordan Justen , FreeBSD Virtualization , Gerd Hoffmann References: <20220329101417.617-1-c.koehne@beckhoff.com> <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> From: "Peter Grehan" In-Reply-To: <7cdf6ac12fbc499fb846f85782d06e21@beckhoff.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=ONO8IRSB c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=8fVbGRnJaTNBnOEn7SCwoA==:17 a=IkcTkHD0fZMA:10 a=z0gMJWrwH1QA:10 a=6I5d2MoRAAAA:8 a=Nkxd-uETkxZAC2387MkA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 4/7/22 3:24 PM, Corvin K=C3=B6hne wrote: > Hi Peter and Rebecca, >=20 > thanks for your feedback. This patch is backward compatible. It checks > if QemuFwCfg is available and if QemuFwCfg is missing it falls > back to BhyveFwCtl. >=20 > So, should I add Reviewed-by (or Acked-by?) Peter and Rebecca to the > commit message? Acked-by: Peter Grehan